From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <pedro@palves.net>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb: make "start" breakpoint inferior-specific
Date: Thu, 10 Nov 2022 12:36:35 -0500 [thread overview]
Message-ID: <a4438bf1-cefc-805c-5f3a-edc2621c6d9d@simark.ca> (raw)
In-Reply-To: <0ebeeb02-db83-53ac-2bcb-05dc92b96316@simark.ca>
>> Even though this does work, it still sets the breakpoint on all the pspaces
>> unnecessarily. It would be nice if the breakpoint was pspace specific, in
>> addition to inferior specific like you have (or some other way). But, what you
>> have is fine with me as is, as it is better than what we have today.
>> Maybe just add a little comment suggesting that it would be even better
>> to make the breakpoint apply to the current pspace only?
>
> Will do.
FWIW, here's what I'm adding
/* To avoid other inferiors hitting this breakpoint, make it
inferior-specific using a condition. A better solution would be to
have proper inferior-specific breakpoint support, in the breakpoint
machinery. We could then avoid inserting a breakpoint in the program
spaces unrelated to this inferior. */
Simon
next prev parent reply other threads:[~2022-11-10 17:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 17:40 [PATCH] " Simon Marchi
2022-08-17 17:56 ` Simon Marchi
2022-08-31 14:03 ` Bruno Larsen
2022-11-04 16:52 ` Simon Marchi
2022-11-07 8:14 ` Bruno Larsen
2022-11-08 17:24 ` Tom Tromey
2022-09-01 10:42 ` Andrew Burgess
2022-11-04 17:24 ` Simon Marchi
[not found] ` <8735asb7cj.fsf@redhat.com>
2022-11-09 13:19 ` Simon Marchi
2022-11-08 19:43 ` Pedro Alves
2022-11-08 20:14 ` Simon Marchi
2022-11-08 21:09 ` Pedro Alves
2022-11-08 21:20 ` [PATCH v2] " Simon Marchi
2022-11-10 16:45 ` Pedro Alves
2022-11-10 17:33 ` Simon Marchi
2022-11-10 17:36 ` Simon Marchi [this message]
2022-11-10 17:47 ` Pedro Alves
2022-11-10 17:53 ` Simon Marchi
2022-11-11 12:37 ` Tom de Vries
2022-11-11 13:53 ` Simon Marchi
2022-11-11 15:21 ` Tom de Vries
2022-11-11 19:03 ` Simon Marchi
2022-11-12 10:43 ` Tom de Vries
2022-11-14 11:29 ` Tom de Vries
2022-11-14 13:19 ` Simon Marchi
2022-11-14 14:18 ` Tom de Vries
2022-11-16 16:22 ` Tom Tromey
2022-11-16 16:26 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4438bf1-cefc-805c-5f3a-edc2621c6d9d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).