public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PING][PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation
Date: Tue, 21 Jun 2022 09:46:58 -0300	[thread overview]
Message-ID: <a5326c70-2de6-e2b7-b086-6a3e3cce7d39@redhat.com> (raw)
In-Reply-To: <20220607195452.40555-1-blarsen@redhat.com>

ping!

Cheers!
Bruno Larsen

On 6/7/22 16:54, Bruno Larsen wrote:
> When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
> only tested objects allocated on the stack. This commit adds a couple of
> dynamic allocations and tests if GDB can stop in it as well.
> ---
> 
> This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
> sure if it is different enough to warrant testing, but I don't think it
> would hurt either.
> 
> ---
>   gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
>   gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
>   2 files changed, 22 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
> index c54b4fece48..faa59f16459 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.cc
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
> @@ -64,5 +64,11 @@ int main()
>        DeeplyDerived's ctor.  */
>     DeeplyDerived dd(15);
>   
> +  Derived *dyn_d = new Derived (24);
> +  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
> +
> +  delete dyn_d;
> +  delete dyn_dd;
> +
>     return 0;
>   }
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
> index cf22be9caa8..4b445635205 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.exp
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
> @@ -59,6 +59,22 @@ gdb_test "continue" \
>   
>   gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
>   
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=24.*" \
> +    "run to breakpoint 1 dynamic v1"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"
> +
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=42.*" \
> +    "run to breakpoint 1 dynamic v2"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"
> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
> +
>   gdb_test "continue" \
>       ".*Breakpoint.*~Derived.*" \
>       "run to breakpoint 3 v1"


  reply	other threads:[~2022-06-21 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 19:54 [PATCH] " Bruno Larsen
2022-06-21 12:46 ` Bruno Larsen [this message]
2022-06-28 18:48   ` [PINGv2][PATCH] " Bruno Larsen
2022-06-30 14:26 ` [PATCH] " Andrew Burgess
2022-06-30 17:14   ` Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5326c70-2de6-e2b7-b086-6a3e3cce7d39@redhat.com \
    --to=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).