[PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[Bruno Larsen]

When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
only tested objects allocated on the stack. This commit adds a couple of
dynamic allocations and tests if GDB can stop in it as well.
---

This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
sure if it is different enough to warrant testing, but I don't think it
would hurt either.

---
 gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
 gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
index c54b4fece48..faa59f16459 100644
--- a/gdb/testsuite/gdb.cp/mb-ctor.cc
+++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
@@ -64,5 +64,11 @@ int main()
      DeeplyDerived's ctor.  */
   DeeplyDerived dd(15);
 
+  Derived *dyn_d = new Derived (24);
+  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
+
+  delete dyn_d;
+  delete dyn_dd;
+
   return 0;
 }
diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
index cf22be9caa8..4b445635205 100644
--- a/gdb/testsuite/gdb.cp/mb-ctor.exp
+++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
@@ -59,6 +59,22 @@ gdb_test "continue" \
 
 gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
 
+gdb_test "continue" \
+    ".*Breakpoint.*Derived.*i=24.*" \
+    "run to breakpoint 1 dynamic v1"
+
+gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"
+
+gdb_test "continue" \
+    ".*Breakpoint.*Derived.*i=42.*" \
+    "run to breakpoint 1 dynamic v2"
+
+gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"
+
+gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
+
+gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
+
 gdb_test "continue" \
     ".*Breakpoint.*~Derived.*" \
     "run to breakpoint 3 v1"
-- 
2.31.1

[PING][PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[Bruno Larsen]

ping!

Cheers!
Bruno Larsen

On 6/7/22 16:54, Bruno Larsen wrote:
> When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
> only tested objects allocated on the stack. This commit adds a couple of
> dynamic allocations and tests if GDB can stop in it as well.
> ---
> 
> This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
> sure if it is different enough to warrant testing, but I don't think it
> would hurt either.
> 
> ---
>   gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
>   gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
>   2 files changed, 22 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
> index c54b4fece48..faa59f16459 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.cc
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
> @@ -64,5 +64,11 @@ int main()
>        DeeplyDerived's ctor.  */
>     DeeplyDerived dd(15);
>   
> +  Derived *dyn_d = new Derived (24);
> +  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
> +
> +  delete dyn_d;
> +  delete dyn_dd;
> +
>     return 0;
>   }
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
> index cf22be9caa8..4b445635205 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.exp
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
> @@ -59,6 +59,22 @@ gdb_test "continue" \
>   
>   gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
>   
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=24.*" \
> +    "run to breakpoint 1 dynamic v1"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"
> +
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=42.*" \
> +    "run to breakpoint 1 dynamic v2"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"
> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
> +
>   gdb_test "continue" \
>       ".*Breakpoint.*~Derived.*" \
>       "run to breakpoint 3 v1"

[PINGv2][PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[Bruno Larsen]

ping!

Cheers!
Bruno Larsen

On 6/21/22 09:46, Bruno Larsen wrote:
> ping!
> 
> Cheers!
> Bruno Larsen
> 
> On 6/7/22 16:54, Bruno Larsen wrote:
>> When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
>> only tested objects allocated on the stack. This commit adds a couple of
>> dynamic allocations and tests if GDB can stop in it as well.
>> ---
>>
>> This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
>> sure if it is different enough to warrant testing, but I don't think it
>> would hurt either.
>>
>> ---
>>   gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
>>   gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
>>   2 files changed, 22 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
>> index c54b4fece48..faa59f16459 100644
>> --- a/gdb/testsuite/gdb.cp/mb-ctor.cc
>> +++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
>> @@ -64,5 +64,11 @@ int main()
>>        DeeplyDerived's ctor.  */
>>     DeeplyDerived dd(15);
>> +  Derived *dyn_d = new Derived (24);
>> +  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
>> +
>> +  delete dyn_d;
>> +  delete dyn_dd;
>> +
>>     return 0;
>>   }
>> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
>> index cf22be9caa8..4b445635205 100644
>> --- a/gdb/testsuite/gdb.cp/mb-ctor.exp
>> +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
>> @@ -59,6 +59,22 @@ gdb_test "continue" \
>>   gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
>> +gdb_test "continue" \
>> +    ".*Breakpoint.*Derived.*i=24.*" \
>> +    "run to breakpoint 1 dynamic v1"
>> +
>> +gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"
>> +
>> +gdb_test "continue" \
>> +    ".*Breakpoint.*Derived.*i=42.*" \
>> +    "run to breakpoint 1 dynamic v2"
>> +
>> +gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"
>> +
>> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
>> +
>> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
>> +
>>   gdb_test "continue" \
>>       ".*Breakpoint.*~Derived.*" \
>>       "run to breakpoint 3 v1"
> 

Re: [PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[Andrew Burgess]

Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

> When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
> only tested objects allocated on the stack. This commit adds a couple of
> dynamic allocations and tests if GDB can stop in it as well.
> ---
>
> This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
> sure if it is different enough to warrant testing, but I don't think it
> would hurt either.

I agree that it can't hurt to include this additional testing.  The
patch looks good, with a minor nit fixed...

>
> ---
>  gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
>  gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
>  2 files changed, 22 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
> index c54b4fece48..faa59f16459 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.cc
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
> @@ -64,5 +64,11 @@ int main()
>       DeeplyDerived's ctor.  */
>    DeeplyDerived dd(15);
>  
> +  Derived *dyn_d = new Derived (24);
> +  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
> +
> +  delete dyn_d;
> +  delete dyn_dd;
> +
>    return 0;
>  }
> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
> index cf22be9caa8..4b445635205 100644
> --- a/gdb/testsuite/gdb.cp/mb-ctor.exp
> +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
> @@ -59,6 +59,22 @@ gdb_test "continue" \
>  
>  gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
>  
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=24.*" \
> +    "run to breakpoint 1 dynamic v1"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"

This line is too long, and can be split like:

  gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" \
      ".* breakpoint here"

> +
> +gdb_test "continue" \
> +    ".*Breakpoint.*Derived.*i=42.*" \
> +    "run to breakpoint 1 dynamic v2"
> +
> +gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"

And again here.

With those fixed, please feel free to apply this patch.

Thanks,
Andrew

> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
> +
> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
> +
>  gdb_test "continue" \
>      ".*Breakpoint.*~Derived.*" \
>      "run to breakpoint 3 v1"
> -- 
> 2.31.1

Re: [PATCH] gdb/testsuite: Expand gdb.cp/mb-ctor.exp to test dynamic allocation

[Bruno Larsen]

thanks, pushed!

Cheers!
Bruno Larsen

On 6/30/22 11:26, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> When testing GDB's ability to stop in constructors, gdb.cp/mb-ctor.exp
>> only tested objects allocated on the stack. This commit adds a couple of
>> dynamic allocations and tests if GDB can stop in it as well.
>> ---
>>
>> This was inspired by an outstanding patch in Fedora's GDB tree. I'm not
>> sure if it is different enough to warrant testing, but I don't think it
>> would hurt either.
> 
> I agree that it can't hurt to include this additional testing.  The
> patch looks good, with a minor nit fixed...
> 
>>
>> ---
>>   gdb/testsuite/gdb.cp/mb-ctor.cc  |  6 ++++++
>>   gdb/testsuite/gdb.cp/mb-ctor.exp | 16 ++++++++++++++++
>>   2 files changed, 22 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.cc b/gdb/testsuite/gdb.cp/mb-ctor.cc
>> index c54b4fece48..faa59f16459 100644
>> --- a/gdb/testsuite/gdb.cp/mb-ctor.cc
>> +++ b/gdb/testsuite/gdb.cp/mb-ctor.cc
>> @@ -64,5 +64,11 @@ int main()
>>        DeeplyDerived's ctor.  */
>>     DeeplyDerived dd(15);
>>   
>> +  Derived *dyn_d = new Derived (24);
>> +  DeeplyDerived *dyn_dd = new DeeplyDerived (42);
>> +
>> +  delete dyn_d;
>> +  delete dyn_dd;
>> +
>>     return 0;
>>   }
>> diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp
>> index cf22be9caa8..4b445635205 100644
>> --- a/gdb/testsuite/gdb.cp/mb-ctor.exp
>> +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp
>> @@ -59,6 +59,22 @@ gdb_test "continue" \
>>   
>>   gdb_continue_to_breakpoint "set breakpoint here, second time" ".* breakpoint here"
>>   
>> +gdb_test "continue" \
>> +    ".*Breakpoint.*Derived.*i=24.*" \
>> +    "run to breakpoint 1 dynamic v1"
>> +
>> +gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" ".* breakpoint here"
> 
> This line is too long, and can be split like:
> 
>    gdb_continue_to_breakpoint "set breakpoint here, first dynamic time" \
>        ".* breakpoint here"
> 
>> +
>> +gdb_test "continue" \
>> +    ".*Breakpoint.*Derived.*i=42.*" \
>> +    "run to breakpoint 1 dynamic v2"
>> +
>> +gdb_continue_to_breakpoint "set breakpoint here, second dynamic time" ".* breakpoint here"
> 
> And again here.
> 
> With those fixed, please feel free to apply this patch.
> 
> Thanks,
> Andrew
> 
>> +
>> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v1"
>> +
>> +gdb_test "continue" ".*Breakpoint.*~Derived.*" "Run to dynamic destructor v2"
>> +
>>   gdb_test "continue" \
>>       ".*Breakpoint.*~Derived.*" \
>>       "run to breakpoint 3 v1"
>> -- 
>> 2.31.1
>