From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Two minor dynamic property fixes
Date: Wed, 1 Mar 2023 13:45:39 -0500 [thread overview]
Message-ID: <a6396180-287b-7e21-7e85-fa560b22c7a9@simark.ca> (raw)
In-Reply-To: <20230301-submit-baton-stuff-v1-0-567d536a8245@adacore.com>
On 3/1/23 10:18, Tom Tromey via Gdb-patches wrote:
> I noticed that dynamic properties were not type-safe or const-correct.
> These two patches fix this. Tested by rebuilding.
>
> Tom
>
> ---
> Tom Tromey (2):
> Make gdb property batons type-safe
> Use const for dwarf2_property_baton
>
> gdb/dwarf2/loc.c | 14 +++++---------
> gdb/dwarf2/loc.h | 2 +-
> gdb/gdbtypes.h | 11 ++++++-----
> 3 files changed, 12 insertions(+), 15 deletions(-)
> ---
> base-commit: 2c29b1ed19711fa2a16558015e5a6b46a09aefeb
> change-id: 20230301-submit-baton-stuff-70d3db0cd50b
>
> Best regards,
> --
> Tom Tromey <tromey@adacore.com>
>
I sent a general design question on patch 1, but otherwise:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2023-03-01 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 15:18 Tom Tromey
2023-03-01 15:18 ` [PATCH 1/2] Make gdb property batons type-safe Tom Tromey
2023-03-01 18:44 ` Simon Marchi
2023-03-01 22:28 ` Tom Tromey
2023-03-01 15:18 ` [PATCH 2/2] Use const for dwarf2_property_baton Tom Tromey
2023-03-01 18:45 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6396180-287b-7e21-7e85-fa560b22c7a9@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).