[PATCH] gdb/mi: remove warning about mi1

[PATCH] gdb/mi: remove warning about mi1

[Simon Marchi]

Remove a warning about mi1.  mi1 was removed in 975249ff4e26 ("Remove MI
version 1").  It is no longer possible to reach this warning, since
trying to use interpreter mi1 bails out before:

    $ ./gdb -nx -q --data-directory=data-directory -i mi1
    Interpreter `mi1' unrecognized

Change-Id: Ie43b21e01bca1407995150c729531a70ee662003
---
 gdb/interps.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/gdb/interps.c b/gdb/interps.c
index adac98125239..f91b2b62c1ba 100644
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -132,16 +132,11 @@ interp_set (struct interp *interp, bool top_level)
   if (interpreter_p != interp->name ())
     interpreter_p = interp->name ();
 
-  bool warn_about_mi1 = false;
-
   /* Run the init proc.  */
   if (!interp->inited)
     {
       interp->init (top_level);
       interp->inited = true;
-
-      if (streq (interp->name (), "mi1"))
-	warn_about_mi1 = true;
     }
 
   /* Do this only after the interpreter is initialized.  */
@@ -151,11 +146,6 @@ interp_set (struct interp *interp, bool top_level)
   clear_interpreter_hooks ();
 
   interp->resume ();
-
-  if (warn_about_mi1)
-    warning (_("MI version 1 is deprecated in GDB 13 and "
-	       "will be removed in GDB 14.  Please upgrade "
-	       "to a newer version of MI."));
 }
 
 /* Look up the interpreter for NAME.  If no such interpreter exists,

base-commit: f8ab027008863bd06513053ea9f84e1116c1cf73
-- 
2.42.0

Re: [PATCH] gdb/mi: remove warning about mi1

[Tom Tromey]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Remove a warning about mi1.  mi1 was removed in 975249ff4e26 ("Remove MI
Simon> version 1").  It is no longer possible to reach this warning, since
Simon> trying to use interpreter mi1 bails out before:

Simon>     $ ./gdb -nx -q --data-directory=data-directory -i mi1
Simon>     Interpreter `mi1' unrecognized

Thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

Re: [PATCH] gdb/mi: remove warning about mi1

[Simon Marchi]

On 9/12/23 14:03, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Remove a warning about mi1.  mi1 was removed in 975249ff4e26 ("Remove MI
> Simon> version 1").  It is no longer possible to reach this warning, since
> Simon> trying to use interpreter mi1 bails out before:
> 
> Simon>     $ ./gdb -nx -q --data-directory=data-directory -i mi1
> Simon>     Interpreter `mi1' unrecognized
> 
> Thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed.

Simon