From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets
Date: Thu, 28 Sep 2023 11:07:26 -0700 [thread overview]
Message-ID: <a8e928da-4b65-617d-dda8-ef8f2dca1c98@FreeBSD.org> (raw)
In-Reply-To: <20230928174752.389177-2-simon.marchi@efficios.com>
On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote:
> They are unused.
>
> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf
> ---
> gdb/netbsd-tdep.c | 15 ---------------
> gdb/netbsd-tdep.h | 3 ---
> 2 files changed, 18 deletions(-)
>
> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c
> index ed60200f958b..15a9e2fd7d4e 100644
> --- a/gdb/netbsd-tdep.c
> +++ b/gdb/netbsd-tdep.c
> @@ -44,21 +44,6 @@
> #define KINFO_VME_FLAG_GROWS_UP 0x00000010
> #define KINFO_VME_FLAG_GROWS_DOWN 0x00000020
>
> -/* FIXME: kettenis/20060115: We should really eliminate the next two
> - functions completely. */
> -
> -struct link_map_offsets *
> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void)
> -{
> - return svr4_ilp32_fetch_link_map_offsets ();
> -}
> -
> -struct link_map_offsets *
> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void)
> -{
> - return svr4_lp64_fetch_link_map_offsets ();
> -}
> -
> int
> nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name)
> {
> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h
> index ab13e628d582..2adf9a751e3b 100644
> --- a/gdb/netbsd-tdep.h
> +++ b/gdb/netbsd-tdep.h
> @@ -20,9 +20,6 @@
> #ifndef NBSD_TDEP_H
> #define NBSD_TDEP_H
>
> -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void);
> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void);
> -
> int nbsd_pc_in_sigtramp (CORE_ADDR, const char *);
>
> /* NetBSD specific set of ABI-related routines. */
Both patches seem sensible to me, and the NetBSD one in particular looks right.
--
John Baldwin
next prev parent reply other threads:[~2023-09-28 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 17:47 [PATCH 1/2] gdb: remove unused imports in solib*.[ch] Simon Marchi
2023-09-28 17:47 ` [PATCH 2/2] gdb: remove nbsd_{ilp32,lp64}_solib_svr4_fetch_link_map_offsets Simon Marchi
2023-09-28 18:07 ` John Baldwin [this message]
2023-09-28 18:24 ` [PATCH 2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets Simon Marchi
2023-09-28 21:05 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e928da-4b65-617d-dda8-ef8f2dca1c98@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).