From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>,
Magne Hov via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 1/2] gdb: keep record of thread numbers for reverse execution targets
Date: Wed, 20 Sep 2023 17:42:46 +0100 [thread overview]
Message-ID: <aa6c9964-6d66-9622-b22d-157e5a6c645f@palves.net> (raw)
In-Reply-To: <871qeu86nm.fsf@tromey.com>
On 2023-09-19 17:33, Tom Tromey wrote:
>>>>>> "Magne" == Magne Hov via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Magne> Targets that support reverse execution may report threads that have
> Magne> previously been seen to exit. Currently, GDB assigns a new thread
> Magne> number every time it sees the same thread (re)appearing, but this is
> Magne> problematic because it makes the output of `info threads` inconsistent,
> Magne> and because thread-specific breakpoints depend on stable thread-numbers
> Magne> in order to stop on the right thread.
>
> Thank you for the patch.
>
> Magne> + std::unordered_map<ptid_t, std::pair<int, int>, hash_ptid> ptid_thread_num_map;
>
> You'll have to update this for the hash_ptid -> std::hash<ptid_t>
> change. However, that's trivial.
I think I have some concerns. Could you hold off a bit?
Sorry I've not managed to stay on top of patch as I'd wish I would.
next prev parent reply other threads:[~2023-09-20 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 8:36 [PATCH 0/2] Improve handling " Magne Hov
2023-06-29 8:36 ` [PATCH 1/2] gdb: keep record " Magne Hov
2023-06-29 9:01 ` Lancelot SIX
2023-06-29 9:38 ` Magne Hov
2023-06-29 8:36 ` [PATCH 2/2] gdb: retain thread-specific breakpoints in " Magne Hov
2023-07-07 16:24 ` [PATCH v2 0/2] Improve handling of thread numbers for " Magne Hov
2023-07-07 16:24 ` [PATCH v2 1/2] gdb: keep record " Magne Hov
2023-07-13 12:21 ` Bruno Larsen
2023-09-19 16:33 ` Tom Tromey
2023-09-20 16:42 ` Pedro Alves [this message]
2023-09-20 17:00 ` Magne Hov
2023-09-20 17:13 ` Pedro Alves
2023-07-07 16:24 ` [PATCH v2 2/2] gdb: retain thread-specific breakpoints in " Magne Hov
2023-07-13 12:22 ` Bruno Larsen
2023-08-18 14:27 ` [PING][PATCH v2 0/2] Improve handling of thread numbers for " Magne Hov
2023-09-18 11:38 ` Magne Hov
2023-09-19 16:34 ` [PATCH " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6c9964-6d66-9622-b22d-157e5a6c645f@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).