From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add type to expression dump of symbol
Date: Thu, 5 Jan 2023 08:48:42 +0100 [thread overview]
Message-ID: <acdd0087-84be-f9c1-a2d2-8454b6043463@redhat.com> (raw)
In-Reply-To: <20230102172813.997882-1-tromey@adacore.com>
On 02/01/2023 18:28, Tom Tromey via Gdb-patches wrote:
> I recently had cause to dump some expressions from gdb. I got output
> like this:
>
> Operation: BINOP_GTR
> Operation: OP_VAR_VALUE
> Block symbol:
> Symbol: small_value
> Block: 0x39b4c20
> Operation: OP_LONG
> Operation: OP_LONG
> Type: int
> Constant: 0x0000000000000014
>
> This is ok, but it would have been handy to see the type of the
> symbol. This ptach adds this information.
s/ptach/patch
Other than that, seems useful and introduces no regressions, so
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-01-05 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 17:28 Tom Tromey
2023-01-05 7:48 ` Bruno Larsen [this message]
2023-01-05 15:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acdd0087-84be-f9c1-a2d2-8454b6043463@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).