Re: [Ping v3] [PATCH 0/4] Add AMX support.

[John Baldwin <jhb@FreeBSD.org>]

I can't formally approve, but this looks fine to me.  I think it's fine to
push this in first and then I can rebase and update my XSAVE layout series
for this and work on getting it merged after this.

On 6/14/22 2:33 AM, Willgerodt, Felix via Gdb-patches wrote:
> *ping* v3
> 
> Thanks,
> Felix
> 
>> -----Original Message-----
>> From: Willgerodt, Felix
>> Sent: Dienstag, 7. Juni 2022 11:14
>> To: gdb-patches@sourceware.org
>> Subject: RE: [Ping v2] [PATCH 0/4] Add AMX support.
>>
>> *ping*
>>
>> Thanks,
>> Felix
>>
>>> -----Original Message-----
>>> From: Willgerodt, Felix
>>> Sent: Freitag, 20. Mai 2022 16:41
>>> To: gdb-patches@sourceware.org
>>> Subject: [Ping] [PATCH 0/4] Add AMX support.
>>>
>>> *Ping*
>>>
>>> I have adapted all of Eli's comments on documentation locally.
>>> They were all straightforward, so I didn't post a v2 for those yet.
>>>
>>> Regards,
>>> Felix
>>>
>>>> -----Original Message-----
>>>> From: Willgerodt, Felix <felix.willgerodt@intel.com>
>>>> Sent: Freitag, 6. Mai 2022 14:12
>>>> To: gdb-patches@sourceware.org
>>>> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
>>>> Subject: [PATCH 0/4] Add AMX support.
>>>>
>>>> Hi all,
>>>>
>>>> This is a series to add support for the new Advanced Matrix Extensions
>>>> (AMX)
>>>> on x86 architectures. They add new registers that require modeling
>>>> in GDB and gdbserver.
>>>>
>>>> Happy about any feedback!
>>>>
>>>> Regards,
>>>> Felix
>>>>
>>>> Aleksandar Paunovic (1):
>>>>    gdb: define int512 and uint512 as built-in types.
>>>>
>>>> Felix Willgerodt (3):
>>>>    gdb, gdbserver: Add AMX registers.
>>>>    gdb, gdbserver: Allocate only a sane amount of buffer when fetching
>>>>      registers.
>>>>    gdb: Clear tilecfg.start_row for any PC modification.
>>>>
>>>>   gdb/amd64-linux-nat.c                         |   2 +
>>>>   gdb/amd64-linux-tdep.c                        |  36 +-
>>>>   gdb/amd64-tdep.c                              | 214 +++++++++++-
>>>>   gdb/amd64-tdep.h                              |   2 +
>>>>   gdb/arch/amd64.c                              |   4 +
>>>>   gdb/doc/gdb.texinfo                           |  44 +++
>>>>   gdb/features/Makefile                         |   1 +
>>>>   gdb/features/i386/64bit-amx.c                 |  60 ++++
>>>>   gdb/features/i386/64bit-amx.xml               |  36 ++
>>>>   gdb/gdbtypes.c                                |   4 +
>>>>   gdb/gdbtypes.h                                |   2 +
>>>>   gdb/i386-linux-tdep.c                         |   2 +
>>>>   gdb/i386-linux-tdep.h                         |   2 +-
>>>>   gdb/i386-tdep.c                               | 321 +++++++++++++++++-
>>>>   gdb/i386-tdep.h                               | 122 ++++++-
>>>>   gdb/i387-tdep.c                               | 156 ++++++++-
>>>>   gdb/i387-tdep.h                               |   8 +
>>>>   gdb/target-descriptions.c                     |   6 +
>>>>   gdb/testsuite/gdb.arch/amd64-amx-corefile.exp | 113 ++++++
>>>>   gdb/testsuite/gdb.arch/amd64-amx-startrow.c   | 122 +++++++
>>>>   gdb/testsuite/gdb.arch/amd64-amx-startrow.exp |  91 +++++
>>>>   gdb/testsuite/gdb.arch/amd64-amx.c            | 173 ++++++++++
>>>>   gdb/testsuite/gdb.arch/amd64-amx.exp          | 231 +++++++++++++
>>>>   gdb/testsuite/lib/gdb.exp                     |  67 ++++
>>>>   gdbserver/i387-fp.cc                          |  70 +++-
>>>>   gdbserver/linux-amd64-ipa.cc                  |   2 +-
>>>>   gdbserver/linux-i386-ipa.cc                   |   2 +-
>>>>   gdbserver/linux-x86-low.cc                    |   4 +-
>>>>   gdbserver/linux-x86-tdesc.cc                  |   3 +
>>>>   gdbserver/linux-x86-tdesc.h                   |   3 +-
>>>>   gdbserver/server.h                            |   2 +-
>>>>   gdbsupport/tdesc.cc                           |   2 +
>>>>   gdbsupport/tdesc.h                            |   2 +
>>>>   gdbsupport/x86-xstate.h                       |  33 +-
>>>>   34 files changed, 1901 insertions(+), 41 deletions(-)
>>>>   create mode 100644 gdb/features/i386/64bit-amx.c
>>>>   create mode 100644 gdb/features/i386/64bit-amx.xml
>>>>   create mode 100644 gdb/testsuite/gdb.arch/amd64-amx-corefile.exp
>>>>   create mode 100644 gdb/testsuite/gdb.arch/amd64-amx-startrow.c
>>>>   create mode 100755 gdb/testsuite/gdb.arch/amd64-amx-startrow.exp
>>>>   create mode 100644 gdb/testsuite/gdb.arch/amd64-amx.c
>>>>   create mode 100755 gdb/testsuite/gdb.arch/amd64-amx.exp
>>>>
>>>> --
>>>> 2.34.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928


-- 
John Baldwin