From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>,
Richard Bunt <Richard.Bunt@arm.com>
Subject: Re: [PATCH v3 5/5] GDB: Introduce limited array lengths while printing values
Date: Fri, 10 Feb 2023 14:18:26 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2302092119250.7841@tpp.orcam.me.uk> (raw)
In-Reply-To: <877cx2l9a1.fsf@tromey.com>
On Tue, 31 Jan 2023, Tom Tromey wrote:
> Maciej> +/* Try to limit ourselves to only fetching the limited number of
> Maciej> + elements. However, if this limited number of elements still
> Maciej> + puts us over max_value_size, then we still throw an error. */
> Maciej> +
> Maciej> +static bool
> Maciej> +set_limited_array_length (struct value *val)
>
> I think the comment is slightly incorrect, in that this doesn't seem to
> throw, but instead returns false.
Yeah, it refers to the invocation of `check_type_length_before_alloc' in
the caller really, which is where this comment was placed previously. I
have updated the wording to:
/* Try to limit ourselves to only fetching the limited number of
elements. However, if this limited number of elements still
puts us over max_value_size, then we still refuse it and
return failure here, which will ultimately throw an error. */
This will be included in the next iteration. Let me know if you have any
concerns about this rewrite.
Maciej
prev parent reply other threads:[~2023-02-10 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 23:00 [PATCH v3 0/5] gdb: introduce " Maciej W. Rozycki
2023-01-23 23:13 ` [PATCH v3 1/5] GDB: Ignore `max-value-size' setting with value history accesses Maciej W. Rozycki
2023-01-31 17:58 ` Tom Tromey
2023-02-10 14:17 ` Maciej W. Rozycki
2023-01-23 23:13 ` [PATCH v3 2/5] GDB: Fix the mess with value byte/bit range types Maciej W. Rozycki
2023-01-31 18:09 ` Tom Tromey
2023-02-10 14:18 ` Maciej W. Rozycki
2023-02-10 14:49 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 3/5] GDB: Only make data actually retrieved into value history available Maciej W. Rozycki
2023-01-31 18:47 ` Tom Tromey
2023-02-10 14:18 ` Maciej W. Rozycki
2023-02-10 21:11 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 4/5] GDB/testsuite: Add `-nonl' option to `gdb_test' Maciej W. Rozycki
2023-01-31 19:02 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 5/5] GDB: Introduce limited array lengths while printing values Maciej W. Rozycki
2023-01-24 12:59 ` Eli Zaretskii
2023-01-31 20:49 ` Tom Tromey
2023-02-10 14:18 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2302092119250.7841@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=Richard.Bunt@arm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).