From: Tom Tromey <tom@tromey.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>,
Tom Tromey <tom@tromey.com>,
Richard Bunt <Richard.Bunt@arm.com>
Subject: Re: [PATCH v3 5/5] GDB: Introduce limited array lengths while printing values
Date: Tue, 31 Jan 2023 13:49:10 -0700 [thread overview]
Message-ID: <877cx2l9a1.fsf@tromey.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2301211719580.7841@tpp.orcam.me.uk> (Maciej W. Rozycki's message of "Mon, 23 Jan 2023 23:14:35 +0000 (GMT)")
>>>>> "Maciej" == Maciej W Rozycki <macro@embecosm.com> writes:
Maciej> From: Andrew Burgess <andrew.burgess@embecosm.com>
Maciej> This commit introduces the idea of loading only part of an array in
Maciej> order to print it, what I call "limited length" arrays.
Maciej> The motivation behind this work is to make it possible to print slices
Maciej> of very large arrays, where very large means bigger than
Maciej> `max-value-size'.
Thanks for the patch.
Maciej> +/* Try to limit ourselves to only fetching the limited number of
Maciej> + elements. However, if this limited number of elements still
Maciej> + puts us over max_value_size, then we still throw an error. */
Maciej> +
Maciej> +static bool
Maciej> +set_limited_array_length (struct value *val)
I think the comment is slightly incorrect, in that this doesn't seem to
throw, but instead returns false.
Other than this nit (no need to resubmit for this), I think this is ok.
Tom
next prev parent reply other threads:[~2023-01-31 20:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 23:00 [PATCH v3 0/5] gdb: introduce " Maciej W. Rozycki
2023-01-23 23:13 ` [PATCH v3 1/5] GDB: Ignore `max-value-size' setting with value history accesses Maciej W. Rozycki
2023-01-31 17:58 ` Tom Tromey
2023-02-10 14:17 ` Maciej W. Rozycki
2023-01-23 23:13 ` [PATCH v3 2/5] GDB: Fix the mess with value byte/bit range types Maciej W. Rozycki
2023-01-31 18:09 ` Tom Tromey
2023-02-10 14:18 ` Maciej W. Rozycki
2023-02-10 14:49 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 3/5] GDB: Only make data actually retrieved into value history available Maciej W. Rozycki
2023-01-31 18:47 ` Tom Tromey
2023-02-10 14:18 ` Maciej W. Rozycki
2023-02-10 21:11 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 4/5] GDB/testsuite: Add `-nonl' option to `gdb_test' Maciej W. Rozycki
2023-01-31 19:02 ` Tom Tromey
2023-01-23 23:14 ` [PATCH v3 5/5] GDB: Introduce limited array lengths while printing values Maciej W. Rozycki
2023-01-24 12:59 ` Eli Zaretskii
2023-01-31 20:49 ` Tom Tromey [this message]
2023-02-10 14:18 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cx2l9a1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Richard.Bunt@arm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).