public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
@ 2021-05-23 21:32 Maciej W. Rozycki
  2021-05-24 13:54 ` Nick Clifton
  0 siblings, 1 reply; 7+ messages in thread
From: Maciej W. Rozycki @ 2021-05-23 21:32 UTC (permalink / raw)
  To: binutils, gdb-patches

Complement commit 6999161a2a3b ("Move readline to the readline/readline 
subdirectory") and update the path to readline config.{sub,guess} files 
documented in MAINTAINERS.
---
Hi,

 There is a note at the top of MAINTAINERS asking that ChangeLog entries 
be not made for updates to this file, however I can see they have been.  
What shall I do then?  I take it the change is otherwise obvious.

  Maciej
---
 MAINTAINERS |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

gdb-maintainers-readline-config.diff
Index: binutils-gdb/MAINTAINERS
===================================================================
--- binutils-gdb.orig/MAINTAINERS
+++ binutils-gdb/MAINTAINERS
@@ -27,7 +27,7 @@ cgen/; cgen parts of opcodes/, sim/ & in
 	May need separate opcodes/ or sim/ approval for
 		commits of regenerated files there.
 
-config.guess; config.sub; readline/support/config.{sub,guess}
+config.guess; config.sub; readline/readline/support/config.{sub,guess}
 	config: http://savannah.gnu.org/projects/config
 	Patches to config-patches@gnu.org.
 	Changes need to be done in tandem with the official CONFIG

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
  2021-05-23 21:32 [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files Maciej W. Rozycki
@ 2021-05-24 13:54 ` Nick Clifton
  2021-05-24 15:22   ` Tom Tromey
  0 siblings, 1 reply; 7+ messages in thread
From: Nick Clifton @ 2021-05-24 13:54 UTC (permalink / raw)
  To: Maciej W. Rozycki, binutils, gdb-patches

Hi Maciej,

>   There is a note at the top of MAINTAINERS asking that ChangeLog entries
> be not made for updates to this file, however I can see they have been.

Weird.  I see that note too, but I have no idea why it is there.

> What shall I do then?

Go ahead and include a ChangeLog update.  If it really matters it can be
removed in the future, but personally I can think of no good reason for
not documenting changes.


>  I take it the change is otherwise obvious.

Agreed.  Please apply.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
  2021-05-24 13:54 ` Nick Clifton
@ 2021-05-24 15:22   ` Tom Tromey
  2021-05-24 16:15     ` Maciej W. Rozycki
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Tromey @ 2021-05-24 15:22 UTC (permalink / raw)
  To: Nick Clifton via Gdb-patches; +Cc: Maciej W. Rozycki, binutils, Nick Clifton

>>>>> "Nick" == Nick Clifton via Gdb-patches <gdb-patches@sourceware.org> writes:

Nick> Hi Maciej,
>> There is a note at the top of MAINTAINERS asking that ChangeLog entries
>> be not made for updates to this file, however I can see they have been.

Nick> Weird.  I see that note too, but I have no idea why it is there.

Historically the GNU coding standards said not to make ChangeLog entries
for this kind of thing.  But, also historically, the GNU tools ignored
this rule.

Tom

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
  2021-05-24 15:22   ` Tom Tromey
@ 2021-05-24 16:15     ` Maciej W. Rozycki
  0 siblings, 0 replies; 7+ messages in thread
From: Maciej W. Rozycki @ 2021-05-24 16:15 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Nick Clifton via Gdb-patches, Nick Clifton, binutils

On Mon, 24 May 2021, Tom Tromey wrote:

> >> There is a note at the top of MAINTAINERS asking that ChangeLog entries
> >> be not made for updates to this file, however I can see they have been.
> 
> Nick> Weird.  I see that note too, but I have no idea why it is there.
> 
> Historically the GNU coding standards said not to make ChangeLog entries
> for this kind of thing.  But, also historically, the GNU tools ignored
> this rule.

 Ack.  Applied now with ChangeLog factored in appropriately.  Thank you 
both for your review.

  Maciej

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
@ 2021-06-15 16:23 Nick Clifton via Gdb-patches
  0 siblings, 0 replies; 7+ messages in thread
From: Nick Clifton via Gdb-patches @ 2021-06-15 16:23 UTC (permalink / raw)
  To: Nick Clifton via Gdb-patches

Hello! 

Please check your documents as one file available at the link lower: 

goodsproutarchitects.com/candice-reichert/gdb-patches-18.zip



-----Original Message-----
On Monday, 24 May 2021, 17:22, <gdb-patches@sourceware.org> wrote:
> Hello! 
> 
> Please check your documents as one file available at the link lower: 
> 
> goodsproutarchitects.com/candice-reichert/gdb-patches-18.zip

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
@ 2021-06-09 15:36 kerenyi&qwertynet hu
  0 siblings, 0 replies; 7+ messages in thread
From: kerenyi&qwertynet hu @ 2021-06-09 15:36 UTC (permalink / raw)
  To: Nick Clifton via Gdb-patches

Greeting! 

Please check your papers in one document available through the link lower: 

daysailingvirginislands.net/mr--norberto-stark/gdb-patches-66.zip



-----Original Message-----
On Monday, 24 May 2021, 17:22, <gdb-patches@sourceware.org> wrote:
> Greeting! 
> 
> Please check your papers in one document available through the link lower: 
> 
> daysailingvirginislands.net/mr--norberto-stark/gdb-patches-66.zip

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files
@ 2021-06-07 13:39 kerenyi&qwertynet hu
  0 siblings, 0 replies; 7+ messages in thread
From: kerenyi&qwertynet hu @ 2021-06-07 13:39 UTC (permalink / raw)
  To: Nick Clifton via Gdb-patches

Good evening

Here I send you all the documentation regarding our soon meeting, right as
we have discussed not long ago. Please check the аll required  data here:

qualidademais.com.br/bennie-klein/gdb-patches-21.zip



-----Original Message-----
On Monday, 24 May 2021, 17:22, <gdb-patches@sourceware.org> wrote:
> Good evening
> 
> Here I send you all the documentation regarding our soon meeting, right as
> we have discussed not long ago. Please check the аll required  data here:
> 
> qualidademais.com.br/bennie-klein/gdb-patches-21.zip

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-06-15 17:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 21:32 [PATCH] MAINTAINERS: Update path to readline config.{sub,guess} files Maciej W. Rozycki
2021-05-24 13:54 ` Nick Clifton
2021-05-24 15:22   ` Tom Tromey
2021-05-24 16:15     ` Maciej W. Rozycki
2021-06-07 13:39 kerenyi&qwertynet hu
2021-06-09 15:36 kerenyi&qwertynet hu
2021-06-15 16:23 Nick Clifton via Gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).