Re: [PATCH 3/5] gdb/python: allow redefinition of python GDB/MI commands

[Jan Vrany <jan.vrany@labware.com>]

Hi, 

thanks! I'd just like to mention that my understanding is that
in the end we'd go with Andrew's rework of this patch series, 
see the thread: 

https://sourceware.org/pipermail/gdb-patches/2022-January/185236.html

and

https://sourceware.org/pipermail/gdb-patches/2022-February/185662.html

Jan


On Sun, 2022-02-06 at 15:33 -0500, Simon Marchi wrote:
> > Here you change the indentation from the previous patch.  This change
> > should probably be moved to it.
> > 
> > I understand that this is tedious to change and am sorry for that.
> 
> Yeah, it looks like there is a good number of changes in this patch that
> adjust things added in the previous patch.  These changes should indeed
> be folded in the previous patch.  I was going to comment on some of them
> only to find out they get changed here, for no particular reason.
> 
> FYI, with the right tools it's not too tedious.  Here's how I do this
> particular change:
> 
> 1. "git config diff.tool meld", to set meld as my diff tool of choice
> 2. use "git rebase -i" to go to patch 2
> 3. "git difftool --dir-diff <sha1-of-patch-3>"
> 
> That opens Meld, showing the diff between patches 2 and 3.  That lets
> you bring in the changes you want from patch 3 to 2.  Once you're done,
> amend the commit, finish the rebase.
> 
> Simon