Re: [PATCH] gdb/testsuite: fix gdb.guile/scm-parameter.exp "wrong type argument" test pattern

[Tom de Vries <tdevries@suse.de>]

On 10/25/22 03:08, Simon Marchi via Gdb-patches wrote:
> 
> 
> On 2022-10-24 19:22, Maciej W. Rozycki wrote:
>> On Mon, 24 Oct 2022, Simon Marchi wrote:
>>
>>> I believe that the first two lines are output by Guile itself, in the
>>> SCM_ASSERT_TYPE macro.  I tried on different systems, different Guile
>>> versions (2.0, 2.2 and 3.0) and I always get the former output, never
>>> the output the test expects.  I presume the patch below isn't right, as
>>> there is surely some systems that do print the latter output, otherwise
>>> Maciej (the original author) would have noticed it.  I presume we'll
>>> need to accept both outputs.  But I'd like we if could clarify when we
>>> get which.
>>
>>   FTR I'm still looking into it and like you I have hesitated to just paper
>> the issue over by allowing both outputs without first understanding what
>> is really going on here.  I cannot rule out a distribution-specific patch
>> causing a discrepancy here, but I feel like tracking it down.
>>
>>   NB guile 2.0.13 here, reporting as:
>>
>> guile (GNU Guile) 2.0.13
>> Packaged by Debian (2.0.13-deb+1-5.4)
> 
> According to that version number, it looks like Ubuntu 20.04?
> 
>    https://packages.ubuntu.com/focal/guile-2.0
> 
> I tried building on Ubuntu 20.04 against guile-2.0, and I see the same
> result as you.  And when I try guile2.0 on Arch Linux (this package
> [1]), I also see the same result as you.  So I must have tested it wrong
> previously.
> 
> You can dig further if you want, but I'd be fine just accepting both
> outputs and saying that guile-2.0 outputs the additional ERROR: while
> subsequent versions do not.
> 

FWIW, I did the same here in commit 6bbe1a929c6 ("[gdb/testsuite] Fix 
gdb.guile/scm-breakpoint.exp with guile 3.0").

Thanks,
- Tom