public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Sobisch <simonsobisch@gnu.org>, gdb-patches@sourceware.org
Subject: Re: source search with correct return type for "Expression not found"
Date: Wed, 3 Nov 2021 20:43:19 -0400	[thread overview]
Message-ID: <b6944f8a-6cbc-9382-316e-fdfc42a273d5@polymtl.ca> (raw)
In-Reply-To: <39e16d91-3de3-2558-9afc-9d777eef7edc@gnu.org>



On 2021-11-03 18:09, Simon Sobisch via Gdb-patches wrote:
> Currently the user only gets output of this message, but not error.
> The later is especially different handled in GDB frontends and with mi
> 
> gdb/source.c, line 1709:
> 
> -  printf_filtered (_("Expression not found\n"));
> +  error (_("Expression not found"));
> 
> Nice side effect: one msgid less, because on line 1649 it is actually used that way.

Hi,

Could you please send a proper git-generated patch (using
git-send-email, ideally)?

Also, in the commit message, please provide an example of the commands
you are using, with their output (before and after), explaining what
needs to be fixed.

Thanks,

Simon

      reply	other threads:[~2021-11-04  0:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 22:09 Simon Sobisch
2021-11-04  0:43 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6944f8a-6cbc-9382-316e-fdfc42a273d5@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=simonsobisch@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).