GDB 13 release -- 2022-11-19 update

GDB 13 release -- 2022-11-19 update

[Joel Brobecker]

Hi everyone,

Here is an update since last time. It feels like we git a significant
influx of new PRs added to the list. Fortunately, have have patches
for many of them.

Additionally, Tom told me last Wed that he's send his last patches
for the DWARF reader, so IIUC, if there are more issues that haven't
been addressed yet, please report them!

Fixed Since the Previous Update:
--------------------------------

  * [TomT] PR c++/29243
    infinite loop in generic_value_print
    https://sourceware.org/bugzilla/show_bug.cgi?id=29243

Added Since the Last Update:
----------------------------

  * [RainerO] PR build/29791
    Many gdbsupport files don't compile on Solaris
    https://sourceware.org/bugzilla/show_bug.cgi?id=29791

     - Patch #1, 2022-11-18, approved same day:
       https://sourceware.org/pipermail/gdb-patches/2022-November/193949.html

     - Patch #2: 2022-11-18, approved same day:
       https://sourceware.org/pipermail/gdb-patches/2022-November/193950.html

  * [TomT] PR gdb/29787
    Bug 29787 - Using "set debug infrun on" and "set logging enabled" breaks GDB prompt and makes GDB crash
    https://sourceware.org/bugzilla/show_bug.cgi?id=29787

    Patch submitted for review 2022-11-17:
    https://sourceware.org/pipermail/gdb-patches/2022-November/193923.html

  * [TomT] cli/29800
    Trying to "document" an undefined command causes crash
    https://sourceware.org/bugzilla/show_bug.cgi?id=29800

    Patch submitted for review 2022-11-18, approved:
    https://sourceware.org/pipermail/gdb-patches/2022-November/193967.html

  * [TomDV,AndrewB] PR python/29712
    UNRESOLVED: gdb.python/py-disasm.exp: global_disassembler=ReadMemoryGdbErrorDisassembler: disassemble test
    https://sourceware.org/bugzilla/show_bug.cgi?id=29712

    TomDV's patches are in. Andrew's latest version (v3) posted
    on 2022-11-18:
    https://sourceware.org/pipermail/gdb-patches/2022-November/193983.html

  * [Torbjorn] tdep/29738
    Arm M-profile dwarf2 unwinder performance suffers from exponential growth
    https://sourceware.org/bugzilla/show_bug.cgi?id=29738

    patch v2, 2022-11-18:
    https://sourceware.org/pipermail/gdb-patches/2022-November/193960.html

Other Ongoing Items:
--------------------

  * [PhilippeW]
    Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno

    v4 (2022-11-12) below, approved Nov 18th:
    https://sourceware.org/pipermail/gdb-patches/2022-November/193758.html

  * [TomT] PR symtab/29105
    new DWARF reader still slow
    https://sourceware.org/bugzilla/show_bug.cgi?id=29105

    The subject of this PR and the initial message mention that
    the index cache is still faster than the new DWARF reader.
    But reading following discussions, it's not clear to me
    anymore what this ticket is about, or what's left to do.
    I will follow up on the PR itself.

-- 
Joel

Re: GDB 13 release -- 2022-11-19 update

[Philippe Waroquiers]

On Sat, 2022-11-19 at 16:42 +0400, Joel Brobecker via Gdb-patches wrote:
> 
> Other Ongoing Items:
> --------------------
> 
>   * [PhilippeW]
>     Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno
After rebase + successfully rerun regression tests,
pushed and marked PR breakpoints/12464 as resolved.


Note that after pushing, I did "git pull" in another worktree and had ctxobj.exp failing.
This test fails randomly depending on the computer load.
This looks to be a missing $gdb_prompt in a gdb_test_multiple regexp.

I will push a fix under the trivial rule as with this fix, I could
not make the ctxobj.exp fail again.

Thanks
Philippe

Re: GDB 13 release -- 2022-11-19 update

[Rainer Orth]

Hi Joel,

> Added Since the Last Update:
> ----------------------------
>
>   * [RainerO] PR build/29791
>     Many gdbsupport files don't compile on Solaris
>     https://sourceware.org/bugzilla/show_bug.cgi?id=29791
>
>      - Patch #1, 2022-11-18, approved same day:
>        https://sourceware.org/pipermail/gdb-patches/2022-November/193949.html
>
>      - Patch #2: 2022-11-18, approved same day:
>        https://sourceware.org/pipermail/gdb-patches/2022-November/193950.html

Only Patch #2 addressed the PR, but both are in now.  This way, trunk
builds again on Solaris, both 32 and 64-bit.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: GDB 13 release -- 2022-11-19 update

[Simon Marchi]

On 11/19/22 07:42, Joel Brobecker via Gdb-patches wrote:
> Hi everyone,
> 
> Here is an update since last time. It feels like we git a significant
> influx of new PRs added to the list. Fortunately, have have patches
> for many of them.
> 
> Additionally, Tom told me last Wed that he's send his last patches
> for the DWARF reader, so IIUC, if there are more issues that haven't
> been addressed yet, please report them!

Hi Joel,

I think this series would be nice to have in GDB 13:

  Fix some commit_resumed_state assertion failures (PR 28275)
  https://inbox.sourceware.org/gdb-patches/20221121171213.1414366-1-simon.marchi@polymtl.ca/T/#m20705093bf5d0feea4f0c54691c61f320e1d162b

Also, do you think there will be a GDB 12.2?  Even if there isn't, I
would probably push the patches to the GDB 12 branch anyway, in case
someone wants to build it from the branch.

Simon

Re: GDB 13 release -- 2022-11-19 update

[Joel Brobecker]

Hi Simon,

On Tue, Nov 22, 2022 at 10:10:53AM -0500, Simon Marchi wrote:
> On 11/19/22 07:42, Joel Brobecker via Gdb-patches wrote:
> > Hi everyone,
> > 
> > Here is an update since last time. It feels like we git a significant
> > influx of new PRs added to the list. Fortunately, have have patches
> > for many of them.
> > 
> > Additionally, Tom told me last Wed that he's send his last patches
> > for the DWARF reader, so IIUC, if there are more issues that haven't
> > been addressed yet, please report them!
> 
> Hi Joel,
> 
> I think this series would be nice to have in GDB 13:
> 
>   Fix some commit_resumed_state assertion failures (PR 28275)
>   https://inbox.sourceware.org/gdb-patches/20221121171213.1414366-1-simon.marchi@polymtl.ca/T/#m20705093bf5d0feea4f0c54691c61f320e1d162b

Sounds good, Simon. I've tagged the PR with a 13.1 milestone.

> Also, do you think there will be a GDB 12.2?  Even if there isn't, I
> would probably push the patches to the GDB 12 branch anyway, in case
> someone wants to build it from the branch.

There weren't enough changes in the gdb-12-branch to warrant
a 12.2 release. We can of course rediscuss, but feel free to
backport the change to the gdb-12-branch regardless. We've done
so before, after .2 releases as well, for the exact reason
you mentioned.

-- 
Joel

Re: GDB 13 release -- 2022-11-19 update

[Simon Marchi]

On 11/22/22 10:31, Joel Brobecker via Gdb-patches wrote:
> Hi Simon,
> 
> On Tue, Nov 22, 2022 at 10:10:53AM -0500, Simon Marchi wrote:
>> On 11/19/22 07:42, Joel Brobecker via Gdb-patches wrote:
>>> Hi everyone,
>>>
>>> Here is an update since last time. It feels like we git a significant
>>> influx of new PRs added to the list. Fortunately, have have patches
>>> for many of them.
>>>
>>> Additionally, Tom told me last Wed that he's send his last patches
>>> for the DWARF reader, so IIUC, if there are more issues that haven't
>>> been addressed yet, please report them!
>>
>> Hi Joel,
>>
>> I think this series would be nice to have in GDB 13:
>>
>>   Fix some commit_resumed_state assertion failures (PR 28275)
>>   https://inbox.sourceware.org/gdb-patches/20221121171213.1414366-1-simon.marchi@polymtl.ca/T/#m20705093bf5d0feea4f0c54691c61f320e1d162b
> 
> Sounds good, Simon. I've tagged the PR with a 13.1 milestone.

Thanks.

> 
>> Also, do you think there will be a GDB 12.2?  Even if there isn't, I
>> would probably push the patches to the GDB 12 branch anyway, in case
>> someone wants to build it from the branch.
> 
> There weren't enough changes in the gdb-12-branch to warrant
> a 12.2 release. We can of course rediscuss, but feel free to
> backport the change to the gdb-12-branch regardless. We've done
> so before, after .2 releases as well, for the exact reason
> you mentioned.

Thanks, will do.

Simon

Re: GDB 13 release -- 2022-11-19 update

[Philippe Waroquiers]

On Sat, 2022-11-19 at 16:42 +0400, Joel Brobecker via Gdb-patches wrote:
> 
>   * [PhilippeW]
>     Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno
> 
>     v4 (2022-11-12) below, approved Nov 18th:
>     https://sourceware.org/pipermail/gdb-patches/2022-November/193758.html
This has been pushed now.
Thanks for Tom for the review and for Simon for reporting regressions
and reviewing the fixes.

As part of the testing of these fixes, valgrind detected a "use of unitialized bit value".
I have sent an RFA with a fix (was sent twice by mistake, the second one is at:
https://sourceware.org/pipermail/gdb-patches/2022-November/194088.html

This fix is likely good to put in 13.0

Thanks
Philippe

 
> 
>   * [TomT] PR symtab/29105
>     new DWARF reader still slow
>     https://sourceware.org/bugzilla/show_bug.cgi?id=29105
> 
>     The subject of this PR and the initial message mention that
>     the index cache is still faster than the new DWARF reader.
>     But reading following discussions, it's not clear to me
>     anymore what this ticket is about, or what's left to do.
>     I will follow up on the PR itself.
>