* [PATCH] Remove mi_version function
@ 2023-03-20 18:27 Tom Tromey
2023-03-20 18:38 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-03-20 18:27 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
The mi_version function is unused, and I think it's better overall if
it is never used. This patch removes it. Tested by rebuilding.
---
gdb/mi/mi-out.c | 6 ------
gdb/mi/mi-out.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/gdb/mi/mi-out.c b/gdb/mi/mi-out.c
index 5ce24a30999..29a416a426d 100644
--- a/gdb/mi/mi-out.c
+++ b/gdb/mi/mi-out.c
@@ -360,12 +360,6 @@ as_mi_ui_out (ui_out *uiout)
return gdb::checked_static_cast<mi_ui_out *> (uiout);
}
-int
-mi_version (ui_out *uiout)
-{
- return as_mi_ui_out (uiout)->version ();
-}
-
void
mi_out_put (ui_out *uiout, struct ui_file *stream)
{
diff --git a/gdb/mi/mi-out.h b/gdb/mi/mi-out.h
index b63492f459c..10c9f8a4585 100644
--- a/gdb/mi/mi-out.h
+++ b/gdb/mi/mi-out.h
@@ -145,7 +145,6 @@ class mi_ui_out : public ui_out
Return nullptr if an invalid version is provided. */
mi_ui_out *mi_out_new (const char *mi_version);
-int mi_version (ui_out *uiout);
void mi_out_put (ui_out *uiout, struct ui_file *stream);
void mi_out_rewind (ui_out *uiout);
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove mi_version function
2023-03-20 18:27 [PATCH] Remove mi_version function Tom Tromey
@ 2023-03-20 18:38 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2023-03-20 18:38 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 3/20/23 14:27, Tom Tromey via Gdb-patches wrote:
> The mi_version function is unused, and I think it's better overall if
> it is never used. This patch removes it. Tested by rebuilding.
LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 18:27 [PATCH] Remove mi_version function Tom Tromey
2023-03-20 18:38 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).