* [PATCH] gdb: fix help doc for "set index-cache enabled"
@ 2021-11-23 16:09 Simon Marchi
2021-11-24 16:25 ` Andrew Burgess
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2021-11-23 16:09 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
When implementing this command, I put "help doc" as a placeholder for
the help string, and forgot to update it. Change it for a real help
string.
Change-Id: Id23c2142c5073dc570bd8a706e9ec6fa8c40eb09
---
gdb/dwarf2/index-cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/index-cache.c b/gdb/dwarf2/index-cache.c
index 06c27db306ff..7cb0fd3d9a1c 100644
--- a/gdb/dwarf2/index-cache.c
+++ b/gdb/dwarf2/index-cache.c
@@ -360,7 +360,7 @@ _initialize_index_cache ()
= add_setshow_boolean_cmd ("enabled", class_files,
_("Enable the index cache."),
_("Show whether the index cache is enabled."),
- _("help doc"),
+ _("When on, enable the use of the index cache."),
set_index_cache_enabled_command,
get_index_cache_enabled_command,
show_index_cache_enabled_command,
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb: fix help doc for "set index-cache enabled"
2021-11-23 16:09 [PATCH] gdb: fix help doc for "set index-cache enabled" Simon Marchi
@ 2021-11-24 16:25 ` Andrew Burgess
2021-11-24 20:07 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2021-11-24 16:25 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-11-23 11:09:43 -0500]:
> When implementing this command, I put "help doc" as a placeholder for
> the help string, and forgot to update it. Change it for a real help
> string.
LGTM.
Thanks,
Andrew
>
> Change-Id: Id23c2142c5073dc570bd8a706e9ec6fa8c40eb09
> ---
> gdb/dwarf2/index-cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/dwarf2/index-cache.c b/gdb/dwarf2/index-cache.c
> index 06c27db306ff..7cb0fd3d9a1c 100644
> --- a/gdb/dwarf2/index-cache.c
> +++ b/gdb/dwarf2/index-cache.c
> @@ -360,7 +360,7 @@ _initialize_index_cache ()
> = add_setshow_boolean_cmd ("enabled", class_files,
> _("Enable the index cache."),
> _("Show whether the index cache is enabled."),
> - _("help doc"),
> + _("When on, enable the use of the index cache."),
> set_index_cache_enabled_command,
> get_index_cache_enabled_command,
> show_index_cache_enabled_command,
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb: fix help doc for "set index-cache enabled"
2021-11-24 16:25 ` Andrew Burgess
@ 2021-11-24 20:07 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2021-11-24 20:07 UTC (permalink / raw)
To: Andrew Burgess, Simon Marchi; +Cc: gdb-patches
On 2021-11-24 11:25 a.m., Andrew Burgess via Gdb-patches wrote:
> * Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-11-23 11:09:43 -0500]:
>
>> When implementing this command, I put "help doc" as a placeholder for
>> the help string, and forgot to update it. Change it for a real help
>> string.
>
> LGTM.
Thanks, pushed.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-24 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 16:09 [PATCH] gdb: fix help doc for "set index-cache enabled" Simon Marchi
2021-11-24 16:25 ` Andrew Burgess
2021-11-24 20:07 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).