From: Richard Bunt <richard.bunt@linaro.org>
To: Tom Tromey <tom@tromey.com>,
Richard Bunt via Gdb-patches <gdb-patches@sourceware.org>
Cc: Josh Cottingham <josh.cottingham@arm.com>
Subject: Re: [PATCH] gdb/mi: Fix printing of fortran strings in stack
Date: Wed, 10 May 2023 17:36:27 +0100 [thread overview]
Message-ID: <c0fe9942-4d9b-6f8f-d7e7-5afadea1ae07@linaro.org> (raw)
In-Reply-To: <87ttwk5jds.fsf@tromey.com>
On 10/05/2023 15:52, Tom Tromey wrote:
>>>>>> "Richard" == Richard Bunt via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Richard> 547ce8f00b4ef826bdc9bf9a74f119fe9768852e fixed an issue where dynamic
> Richard> types were not being resolved correctly prior to printing a value. The
> Richard> same issue was discovered when printing the value using MI-mode. Solved
> Richard> by porting the fix to the MI mode code path.
>
Hi Tom,
Thanks for pointing me in the direction of that patch set.
> I wonder if this can be fixed more directly after
> 2fc3b8a4cb8439fc53975c4e70336d76e3ddc531 and its predecessors.
> (Not that there's anything wrong with this patch.)
>
> Tom
Even better than that, it fixes the issue I was seeing. I mistakenly
thought I was sufficiently in a corner that I'd not need to retest for
the failure after rebasing.
If it is OK, I'd like to propose the test case for upstream as I believe
it covers a legitimate gap, even if there is no known bug here.
Many thanks,
Rich.
next prev parent reply other threads:[~2023-05-10 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 10:20 Richard Bunt
2023-05-10 13:13 ` Andrew Burgess
2023-05-10 14:52 ` Tom Tromey
2023-05-10 16:36 ` Richard Bunt [this message]
2023-05-12 18:38 ` Tom Tromey
2023-05-16 16:24 ` Richard Bunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0fe9942-4d9b-6f8f-d7e7-5afadea1ae07@linaro.org \
--to=richard.bunt@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=josh.cottingham@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).