From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] gdb: add inferior parameter to set_target_gdbarch, rename to set_inferior_gdbarch
Date: Thu, 24 Nov 2022 11:47:44 -0500 [thread overview]
Message-ID: <c1314268-39c6-ab97-07a3-285b1de18561@polymtl.ca> (raw)
In-Reply-To: <20221124164154.sp7zrcpdfkzodjy4@ubuntu.lan>
On 11/24/22 11:42, Lancelot SIX wrote:
> On Thu, Nov 24, 2022 at 11:04:25AM -0500, Simon Marchi via Gdb-patches wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> Add an inferior parameter, so it doesn't depend on the current
>> inferior. While at it, rename to set_inferior_gdbarch, I think that's a
>> better name than "target".
>>
>> The sole observer of the architecture_changed observable,
>> pyuw_on_new_gdbarch, doesn't seem to depend on the current inferior.
>> Neither does registers_changed.
>
> Hi,
>
> I kind of feel that it would make sense to also change the type of the
> architecture_changed observable so the observers receive the inferior *
> and the gdbarch *. It will not be used at the moment, but makes it
> clearer that this observable gets triggerd for a given inferior.
>
> WDYT?
That's a good idea, I'll add a patch that does that to my next version.
Simon
next prev parent reply other threads:[~2022-11-24 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 16:04 [PATCH 0/5] Make some functions independent of current inferior Simon Marchi
2022-11-24 16:04 ` [PATCH 1/5] gdb: add inferior parameter to target_current_description Simon Marchi
2022-11-24 16:04 ` [PATCH 2/5] gdb: add inferior parameter to set_target_gdbarch, rename to set_inferior_gdbarch Simon Marchi
2022-11-24 16:42 ` Lancelot SIX
2022-11-24 16:47 ` Simon Marchi [this message]
2022-11-24 16:04 ` [PATCH 3/5] gdb: add inferior parameter to gdbarch_update_p Simon Marchi
2022-11-24 16:04 ` [PATCH 4/5] gdb: add inferior parameter to target_find_description Simon Marchi
2022-11-24 16:25 ` Simon Marchi
2022-11-24 16:04 ` [PATCH 5/5] gdb: add inferior parameter to target_clear_description Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1314268-39c6-ab97-07a3-285b1de18561@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).