Re: [PATCH] gdb: remove SYMBOL_*_OPS macros

[Simon Marchi <simark@simark.ca>]

On 1/19/24 12:06, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in
> Simon> favor of methods on struct symbol.  More changes could be done here to
> Simon> improve the design and make things safer, but I just wanted to do a
> Simon> straightforward change to remove the macros for now.
> 
> Thanks.
> 
> Simon> +  if (auto computed_ops = var->computed_ops ())
> Simon> +    return computed_ops->read_variable (var, frame);
> 
> This one spot uses auto, but no other change does.
> That seemed weird.  Normally I wouldn't mention it but I also noticed:

I initially used auto everywhere (kinda used to that now, because of
other projects), but then reverted it because in GDB so far we prefer
not to do that.  I missed that spot.

> 
> Simon> +      if (framefunc != nullptr)
> Simon> +      {
> 
> Looks like the wrong indentation here.

Will fix and send a v2, thanks.

Simon