[PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[Andrew Burgess]

Rename 'set debug lin-lwp' to 'set debug linux-native' and 'show debug
lin-lwp' to 'show debug linux-native'.

I've updated the documentation and help text to match, as well as
making it clear that the debug that is coming out relates to all
aspects of Linux native inferior support, not just the LWP aspect of
it.

The boundary between general "native" target debug, and the lwp
specific part of that debug was always a little blurry, but the actual
debug variable inside GDB is debug_linux_nat, and the print routine
linux_nat_debug_printf, is used throughout the linux-nat.c file, not
just for lwp related debug, so the new name seems to make more sense.

I've left the tag that is printed in the debug messages as [linux-nat]
so that the actual debug output doesn't change, and the debug lines
don't get any longer.  I could change the tag to match the switch, or
update the switch to 'linux-nat' if people thing that would be better.
---
 gdb/NEWS                                  | 12 ++++++++++++
 gdb/doc/gdb.texinfo                       | 12 ++++++------
 gdb/linux-nat.c                           |  6 +++---
 gdb/testsuite/gdb.threads/ia64-sigill.exp |  2 +-
 4 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index 1e4afa91bc5..a8ec8905247 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -64,6 +64,12 @@ set debug threads on|off
 show debug threads
   Print additional debug messages about thread creation and deletion.
 
+set debug linux-native on|off
+show debug linux-native
+  These new commands replaced the old 'set debug lin-lwp' and 'show
+  debug lin-lwp' respectively.  Turning this setting on prints debug
+  messages relating to GDB's handling of native Linux inferiors.
+
 * Changed commands
 
 maint packet
@@ -72,6 +78,12 @@ maint packet
   as escaped hex, e.g. \x?? where '??' is replaces with the value of
   the non-printable character.
 
+set debug lin-lwp on|off
+show debug lin-lwp
+  These commands have been removed from GDB.  The new command 'set
+  debug linux-native' and 'show debug linux-native' should be used
+  instead.
+
 * Python API
 
   ** New function gdb.add_history(), which takes a gdb.Value object
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 2d3414175c1..dfcc7cbb386 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27024,12 +27024,12 @@
 @item show debug jit
 Displays the current state of @value{GDBN} JIT debugging.
 
-@item set debug lin-lwp
-@cindex @sc{gnu}/Linux LWP debug messages
-@cindex Linux lightweight processes
-Turn on or off debugging messages from the Linux LWP debug support.
-@item show debug lin-lwp
-Show the current state of Linux LWP debugging messages.
+@item set debug linux-native @r{[}on@r{|}off@r{]}
+@cindex @sc{gnu}/Linux native target debug messages
+@cindex Linux native targets
+Turn on or off debugging messages from the Linux native target debug support.
+@item show debug linux-native
+Show the current state of Linux native target debugging messages.
 
 @item set debug linux-namespaces
 @cindex @sc{gnu}/Linux namespaces debug messages
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 59924873915..bb5d2878433 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -195,13 +195,13 @@ enum tribool have_ptrace_getregset = TRIBOOL_UNKNOWN;
 
 static bool debug_linux_nat;
 
-/* Implement 'show debug lin-lwp'.  */
+/* Implement 'show debug linux-native'.  */
 
 static void
 show_debug_linux_nat (struct ui_file *file, int from_tty,
 		      struct cmd_list_element *c, const char *value)
 {
-  fprintf_filtered (file, _("Debugging of GNU/Linux lwp module is %s.\n"),
+  fprintf_filtered (file, _("Debugging of GNU/Linux native targets is %s.\n"),
 		    value);
 }
 
@@ -4529,7 +4529,7 @@ void _initialize_linux_nat ();
 void
 _initialize_linux_nat ()
 {
-  add_setshow_boolean_cmd ("lin-lwp", class_maintenance,
+  add_setshow_boolean_cmd ("linux-native", class_maintenance,
 			   &debug_linux_nat, _("\
 Set debugging of GNU/Linux native target."), _("	\
 Show debugging of GNU/Linux native target."), _("	\
diff --git a/gdb/testsuite/gdb.threads/ia64-sigill.exp b/gdb/testsuite/gdb.threads/ia64-sigill.exp
index 636b387d388..6322acae210 100644
--- a/gdb/testsuite/gdb.threads/ia64-sigill.exp
+++ b/gdb/testsuite/gdb.threads/ia64-sigill.exp
@@ -55,7 +55,7 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"]
 
 gdb_test_no_output "set debug infrun 1"
 
-# The ia64 SIGILL signal is visible only in the lin-lwp debug.
+# The ia64 SIGILL signal is visible only in the linux-native debug output.
 
 set prompt "$gdb_prompt \\\[infrun\\\] fetch_inferior_event: exit\r\n$"
 gdb_test_multiple "continue" "continue" -prompt $prompt {
-- 
2.25.4

Re: [PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[John Baldwin]

On 12/22/21 9:19 AM, Andrew Burgess via Gdb-patches wrote:
> Rename 'set debug lin-lwp' to 'set debug linux-native' and 'show debug
> lin-lwp' to 'show debug linux-native'.
> 
> I've updated the documentation and help text to match, as well as
> making it clear that the debug that is coming out relates to all
> aspects of Linux native inferior support, not just the LWP aspect of
> it.
> 
> The boundary between general "native" target debug, and the lwp
> specific part of that debug was always a little blurry, but the actual
> debug variable inside GDB is debug_linux_nat, and the print routine
> linux_nat_debug_printf, is used throughout the linux-nat.c file, not
> just for lwp related debug, so the new name seems to make more sense.
> 
> I've left the tag that is printed in the debug messages as [linux-nat]
> so that the actual debug output doesn't change, and the debug lines
> don't get any longer.  I could change the tag to match the switch, or
> update the switch to 'linux-nat' if people thing that would be better.

This looks good to me.  I have no preference on the name (linux-nat vs
linux-native).

-- 
John Baldwin

Re: [PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[Tom Tromey]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Rename 'set debug lin-lwp' to 'set debug linux-native' and 'show debug
Andrew> lin-lwp' to 'show debug linux-native'.

FWIW this name change is fine by me.

Tom

Re: [PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[Simon Marchi]

On 2022-01-11 16:15, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Andrew> Rename 'set debug lin-lwp' to 'set debug linux-native' and 'show debug
> Andrew> lin-lwp' to 'show debug linux-native'.
> 
> FWIW this name change is fine by me.
> 
> Tom

LGTM too.  I would just suggest using "linux-nat" instead of "linux-native", just
so that it matches the logging tag.  It also matches "set debug fbsd-nat".  But
really that is fine with me either way.

Simon

Re: [PATCH] gdb: rename lin-lwp to linux-native in set/show debug

[Andrew Burgess]

Thank you everyone for your feedback.

I switch the controlling flag to 'linux-nat' as was suggested, and
pushed this patch.  What I pushed is included below.

Thanks,
Andrew

---

commit 8864ef428d92e58b48ec11136d3b91622345c838
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Wed Dec 22 15:33:38 2021 +0000

    gdb: rename lin-lwp to linux-nat in set/show debug
    
    Rename 'set debug lin-lwp' to 'set debug linux-nat' and 'show debug
    lin-lwp' to 'show debug linux-nat'.
    
    I've updated the documentation and help text to match, as well as
    making it clear that the debug that is coming out relates to all
    aspects of Linux native inferior support, not just the LWP aspect of
    it.
    
    The boundary between general "native" target debug, and the lwp
    specific part of that debug was always a little blurry, but the actual
    debug variable inside GDB is debug_linux_nat, and the print routine
    linux_nat_debug_printf, is used throughout the linux-nat.c file, not
    just for lwp related debug, so the new name seems to make more sense.

diff --git a/gdb/NEWS b/gdb/NEWS
index c26e15b530a..ad80e92700e 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -64,6 +64,12 @@ set debug threads on|off
 show debug threads
   Print additional debug messages about thread creation and deletion.
 
+set debug linux-nat on|off
+show debug linux-nat
+  These new commands replaced the old 'set debug lin-lwp' and 'show
+  debug lin-lwp' respectively.  Turning this setting on prints debug
+  messages relating to GDB's handling of native Linux inferiors.
+
 * Changed commands
 
 maint packet
@@ -79,6 +85,12 @@ clone-inferior
   environment' or 'unset environment' commands are also copied to the new
   inferior.
 
+set debug lin-lwp on|off
+show debug lin-lwp
+  These commands have been removed from GDB.  The new command 'set
+  debug linux-nat' and 'show debug linux-nat' should be used
+  instead.
+
 * Python API
 
   ** New function gdb.add_history(), which takes a gdb.Value object
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 48873aa34fe..e39815d5132 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27028,12 +27028,12 @@
 @item show debug jit
 Displays the current state of @value{GDBN} JIT debugging.
 
-@item set debug lin-lwp
-@cindex @sc{gnu}/Linux LWP debug messages
-@cindex Linux lightweight processes
-Turn on or off debugging messages from the Linux LWP debug support.
-@item show debug lin-lwp
-Show the current state of Linux LWP debugging messages.
+@item set debug linux-nat @r{[}on@r{|}off@r{]}
+@cindex @sc{gnu}/Linux native target debug messages
+@cindex Linux native targets
+Turn on or off debugging messages from the Linux native target debug support.
+@item show debug linux-nat
+Show the current state of Linux native target debugging messages.
 
 @item set debug linux-namespaces
 @cindex @sc{gnu}/Linux namespaces debug messages
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 2271cbf1532..b926fb5eba9 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -195,13 +195,13 @@ enum tribool have_ptrace_getregset = TRIBOOL_UNKNOWN;
 
 static bool debug_linux_nat;
 
-/* Implement 'show debug lin-lwp'.  */
+/* Implement 'show debug linux-nat'.  */
 
 static void
 show_debug_linux_nat (struct ui_file *file, int from_tty,
 		      struct cmd_list_element *c, const char *value)
 {
-  fprintf_filtered (file, _("Debugging of GNU/Linux lwp module is %s.\n"),
+  fprintf_filtered (file, _("Debugging of GNU/Linux native targets is %s.\n"),
 		    value);
 }
 
@@ -4529,7 +4529,7 @@ void _initialize_linux_nat ();
 void
 _initialize_linux_nat ()
 {
-  add_setshow_boolean_cmd ("lin-lwp", class_maintenance,
+  add_setshow_boolean_cmd ("linux-nat", class_maintenance,
 			   &debug_linux_nat, _("\
 Set debugging of GNU/Linux native target."), _("	\
 Show debugging of GNU/Linux native target."), _("	\
diff --git a/gdb/testsuite/gdb.threads/ia64-sigill.exp b/gdb/testsuite/gdb.threads/ia64-sigill.exp
index 89b684064df..e92b4877b2c 100644
--- a/gdb/testsuite/gdb.threads/ia64-sigill.exp
+++ b/gdb/testsuite/gdb.threads/ia64-sigill.exp
@@ -55,7 +55,7 @@ gdb_breakpoint [gdb_get_line_number "break-at-exit"]
 
 gdb_test_no_output "set debug infrun 1"
 
-# The ia64 SIGILL signal is visible only in the lin-lwp debug.
+# The ia64 SIGILL signal is visible only in the linux-nat debug output.
 
 set prompt "$gdb_prompt \\\[infrun\\\] fetch_inferior_event: exit\r\n$"
 gdb_test_multiple "continue" "continue" -prompt $prompt {