From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Move getopt checking inside SIM_AC_PLATFORM
Date: Thu, 5 Jan 2023 12:38:48 +0900 [thread overview]
Message-ID: <c7f5a23d-c5c5-def9-e40f-3103bf111c89@irq.a4lg.com> (raw)
In-Reply-To: <Y7Ttgh9HWAb1WwnL@vapier>
On 2023/01/04 12:07, Mike Frysinger wrote:
> On 04 Jan 2023 02:01, Tsukasa OI wrote:
>> +dnl Determine whether we have a known getopt prototype in unistd.h
>> +dnl to make sure that we have correct getopt declaration on
>> +dnl include/getopt.h.
>
> this comment should note that this logic is kept in sync with other
> projects like binutils/configure.ac.
>
> otherwise lgtm, thanks
> -mike
Committed with changes you suggested (since the logic hasn't changed, I
consider this is a trivial change).
Thanks,
Tsukasa
prev parent reply other threads:[~2023-01-05 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 2:01 Tsukasa OI
2023-01-04 3:07 ` Mike Frysinger
2023-01-05 3:38 ` Tsukasa OI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f5a23d-c5c5-def9-e40f-3103bf111c89@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).