From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb] Add tsan-suppressions.txt
Date: Tue, 12 Jul 2022 13:46:15 +0200 [thread overview]
Message-ID: <caeae89c-4d5a-413d-af03-a7364d96754c@suse.de> (raw)
In-Reply-To: <b01d7e9c-0ae4-653c-bdc6-cf65b6653ebe@suse.de>
On 7/12/22 12:31, Tom de Vries wrote:
> On 7/12/22 10:39, Tom de Vries wrote:
>> On 7/11/22 12:08, Tom de Vries wrote:
>>> Hi,
>>>
>>> Add a new file tsan-suppressions.txt, to suppress the "unlock
>>> unlocked mutex"
>>> problem in ncurses, filed in PR29328.
>>>
>>> For now, one needs to specify it manually using something like:
>>> ...
>>> $ export TSAN_OPTIONS=suppressions=$(pwd
>>> -P)/src/gdb/tsan-suppressions.txt
>>> ...
>>>
>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29328
>>>
>>> Any comments?
>>>
>>
>> I just found that we already set ASAN_OPTIONS in lib/gdb.exp, so I've
>> added this TSAN_OPTIONS setting alongside.
>
> I furthermore realized that suppression files are not cumulative, so if
> we have suppressions=a.txt:suppressions=b.txt then only b.txt is used.
>
> This would mean we ignore any user-specified suppression files, which
> may contains more suppressions for whatever reason.
>
> So I've updated the patch to only add the suppressions if the user
> didn't already do that.
Well, that makes the whole thing harmless enough, so committed.
Thanks,
- Tom
prev parent reply other threads:[~2022-07-12 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 10:08 [PATCH][gdb] " Tom de Vries
2022-07-12 8:39 ` Tom de Vries
2022-07-12 10:31 ` Tom de Vries
2022-07-12 11:46 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caeae89c-4d5a-413d-af03-a7364d96754c@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).