From: Bruno Larsen <blarsen@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 10/15] explicitly test for stderr in gdb.base/dprintf.exp
Date: Tue, 13 Sep 2022 14:08:08 +0200 [thread overview]
Message-ID: <cbaceab3-865f-b449-4acc-6fd86e8ac674@redhat.com> (raw)
In-Reply-To: <87edwglr73.fsf@redhat.com>
Thanks, pushed!
Cheers,
Bruno
On 12/09/2022 14:20, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> Not all compilers add stderr debug information when compiling a
>> program. Clang, for instance, prefers to add nothing from standard
>> libraries and let an external debug package have this information.
>> Because of this, gdb.base/dprintf.exp was failing when GDB attempted to
>> use dprintf as a call to fprintf(stderrr, ...), like this:
>>
>> (gdb) PASS: gdb.base/dprintf.exp: call: fprintf: set dprintf style to call
>> continue
>> Continuing.
>> kickoff 1234
>> also to stderr 1234
>> 'stderr' has unknown type; cast it to its declared type
>> (gdb) FAIL: gdb.base/dprintf.exp: call: fprintf: 1st dprintf (timeout)
>>
>> To avoid this false positive, we explicitly test to see if
>> the compiler has added information about stderr at all, and abort
>> testing dprintf as an fprintf call if it is unavailable.
>> ---
>> gdb/testsuite/gdb.base/dprintf.exp | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.base/dprintf.exp b/gdb/testsuite/gdb.base/dprintf.exp
>> index 0b209c02a62..e214531f6dc 100644
>> --- a/gdb/testsuite/gdb.base/dprintf.exp
>> +++ b/gdb/testsuite/gdb.base/dprintf.exp
>> @@ -111,6 +111,16 @@ proc test_call {} {
>> test_dprintf "At foo entry.*arg=1235, g=2222\r\n" "2nd dprintf"
>> }
>>
>> + gdb_test_multiple "print stderr" "stderr symbol check" {
>> + -re "\\'stderr\\' has unknown type.*" {
>> + untested "No information available for stderr, exiting early"
>> + return
>> + }
>> + -re "\\\$1.*" {
>> + pass "stderr is available"
> I think this should be `pass $gdb_test_name`, but OK to commit with that
> change.
>
> Thanks,
> Andrew
>
>> + }
>> + }
>> +
>> with_test_prefix "fprintf" {
>> restart
>>
>> --
>> 2.31.1
next prev parent reply other threads:[~2022-09-13 12:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:44 [PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 01/15] gdb/testsuite: introduce gdb_step_until_regexp Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 02/15] gdb/testsuite: Add a proc to test where compiler links the epilogue Bruno Larsen
2022-09-13 12:17 ` Andrew Burgess
2022-07-20 19:44 ` [PATCH v4 03/15] Change gdb.base/skip-solib.exp deal with lack of epilogue information Bruno Larsen
2022-09-10 9:53 ` Andrew Burgess
2022-07-20 19:44 ` [PATCH v4 04/15] gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang Bruno Larsen
2022-09-12 9:08 ` Andrew Burgess
2022-09-12 12:17 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 05/15] update gdb.base/info-program.exp " Bruno Larsen
2022-09-12 9:34 ` Andrew Burgess
2022-09-12 12:18 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing Bruno Larsen
2022-09-12 9:41 ` Andrew Burgess
2022-09-12 12:18 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 07/15] Fix gdb.base/call-ar-st to work with Clang Bruno Larsen
2022-09-12 10:30 ` Andrew Burgess
2022-09-12 12:18 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang Bruno Larsen
2022-09-12 10:49 ` Andrew Burgess
2022-09-12 12:18 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 09/15] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang Bruno Larsen
2022-09-12 10:58 ` Andrew Burgess
2022-09-12 12:30 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 10/15] explicitly test for stderr in gdb.base/dprintf.exp Bruno Larsen
2022-09-12 12:20 ` Andrew Burgess
2022-09-13 12:08 ` Bruno Larsen [this message]
2022-07-20 19:44 ` [PATCH v4 11/15] gdb/testsuite: Update gdb.base/so-impl-ld.exp Bruno Larsen
2022-09-12 12:30 ` Andrew Burgess
2022-09-13 12:08 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 12/15] [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang Bruno Larsen
2022-09-12 12:54 ` Andrew Burgess
2022-07-20 19:44 ` [PATCH v4 13/15] gdb/testsuite: fix gdb.base/info-types-c++ " Bruno Larsen
2022-09-12 14:35 ` Andrew Burgess
2022-09-14 11:31 ` Bruno Larsen
2022-07-20 19:44 ` [PATCH v4 14/15] gdb.base/skip.exp: Use finish to exit functions Bruno Larsen
2022-09-12 16:57 ` Andrew Burgess
2022-07-20 19:44 ` [PATCH v4 15/15] gdb/testsuite: Add test to step through function epilogue Bruno Larsen
2022-09-08 12:04 ` Andrew Burgess
2022-08-09 16:53 ` [PIING][PATCH v4 00/15] Clean gdb.base when testing with clang Bruno Larsen
2022-08-18 7:25 ` [PINGv2][PATCH " Bruno Larsen
2022-08-25 7:51 ` [PINGv3][PATCH " Bruno Larsen
2022-09-05 14:59 ` [PINGv4][PATCH " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbaceab3-865f-b449-4acc-6fd86e8ac674@redhat.com \
--to=blarsen@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).