Re: [PATCH v4 08/15] add xfails to gdb.base/complex-parts.exp when testing with clang

[Bruno Larsen <blarsen@redhat.com>]

thanks, pushed!

Cheers,
Bruno

On 12/09/2022 12:49, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> clang doesn't add encoding to the name of complex variables, only says
>> that the type name is complex, making the relevant tests fail.
>> This patch adds the xfails to the tests that expect the variable name to
>> include it.
>> ---
>>   gdb/testsuite/gdb.base/complex-parts.exp | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/gdb/testsuite/gdb.base/complex-parts.exp b/gdb/testsuite/gdb.base/complex-parts.exp
>> index e67fd482268..7fa94c72cd4 100644
>> --- a/gdb/testsuite/gdb.base/complex-parts.exp
>> +++ b/gdb/testsuite/gdb.base/complex-parts.exp
>> @@ -30,8 +30,13 @@ gdb_test "p z1" " = 1.5 \\+ 4.5i"
>>   gdb_test "p z2" " = 2.5 \\+ -5.5i"
>>   gdb_test "p z3" " = 3.5 \\+ 6.5i"
>>   
>> +# The following 3 tests are broken for Clang.
>> +# More info at https://github.com/llvm/llvm-project/issues/52996.
>> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* }
>>   gdb_test "ptype z1" " = complex double"
>> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* }
>>   gdb_test "ptype z2" " = complex float"
>> +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* }
>>   gdb_test "ptype z3" " = complex long double"
>>   
>>   with_test_prefix "double imaginary" {
> LGTM.  Please go ahead and apply.
>
> Thanks,
> Andrew
>