From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow 'ptype/o' for assembly
Date: Tue, 8 Nov 2022 13:19:57 -0800 [thread overview]
Message-ID: <cdbb5d9d-6a4a-fdad-d216-7391da148c7f@redhat.com> (raw)
In-Reply-To: <20221108201452.1255047-1-tromey@adacore.com>
On 11/8/22 12:14, Tom Tromey via Gdb-patches wrote:
> PR exp/28359 points out that 'ptype/o' does not work when the current
> language is "asm".
>
I hesitate to bring this up, but...
Why would the current language matter in this case?
[I understand that the print options are set before
the expression is evaluated...]
Since we have the type of the symbol, couldn't we
simply use that? Maybe it's not worth being so
pedantic?
In any case, it LGTM. I recommend you approve your patch.
Keith
next prev parent reply other threads:[~2022-11-08 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 20:14 Tom Tromey
2022-11-08 21:19 ` Keith Seitz [this message]
2022-11-09 15:28 ` Tom Tromey
2022-11-11 19:50 ` Philippe Waroquiers
2022-11-14 13:32 ` Tom Tromey
2022-11-14 20:05 ` Philippe Waroquiers
2022-11-09 14:47 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdbb5d9d-6a4a-fdad-d216-7391da148c7f@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).