From: Simon Marchi <simark@simark.ca>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gdb-patches@sourceware.org
Subject: Re: [PATCH][PR build/29791] gnulib: Disable _GL_ATTRIBUTE_DEALLOC on Solaris
Date: Fri, 18 Nov 2022 11:00:40 -0500 [thread overview]
Message-ID: <cec4e8a7-6c55-aa53-3395-b04c6ec239d3@simark.ca> (raw)
In-Reply-To: <yddmt8o76l7.fsf@CeBiTec.Uni-Bielefeld.DE>
On 11/18/22 08:08, Rainer Orth wrote:
> gdbsupport compilation badly fails with GCC 12 on Solaris, with errors
> like
>
> ../gnulib/config.h:1693:72: error: ‘malloc’ attribute argument 1 is ambiguous
> 1693 | # define _GL_ATTRIBUTE_DEALLOC(f, i) __attribute__ ((__malloc__ (f, i)))
> | ^
> ../gnulib/config.h:1693:72: note: use a cast to the expected type to disambiguate
>
> We've not yet been able to determine where the ambiguity actually lies,
> so this patch works around the issue by disabling _GL_ATTRIBUTE_DEALLOC
> on Solaris, at least as a workaround for GDB 13.
>
> As Tom suggested in the PR, this is done using our infrastructure for
> local gnulib patches.
>
> Tested on sparcv9-sun-solaris2.11, amd64-pc-solaris2.11, and
> x86_64-pc-linux-gnu.
>
> Ok for trunk?
Thanks, this is ok:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2022-11-18 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 13:08 Rainer Orth
2022-11-18 16:00 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec4e8a7-6c55-aa53-3395-b04c6ec239d3@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).