public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Improvements for Pygments based disassembly styling
Date: Tue, 30 Aug 2022 15:16:50 +0100	[thread overview]
Message-ID: <cover.1661868744.git.aburgess@redhat.com> (raw)

This series was inspired by this stackoverflow post:

  https://stackoverflow.com/questions/73491793/why-is-there-a-%c2%b1-in-lea-rax-rip-%c2%b1-0xeb3

which highlighted some issues with the Python Pygments based
disassembler styling that was being used for all architectures in GDB
12.

The next release of GDB will use libopcodes styling for many of the
most popular architectures, but lots of the smaller architectures are
still using Pygments, and Pygments can still be used for all
architectures if a user chooses to disable use of libopcodes styling,
though I don't know why they would want to do that.

---

Andrew Burgess (3):
  gdb/testsuite: extend styling test for libopcodes styling
  gdb: improve disassembler styling when Pygments raises an exception
  gdb/disasm: better intel flavour disassembly styling with Pygments

 gdb/disasm.c                     |  69 ++++++++++----
 gdb/disasm.h                     |  21 +++-
 gdb/python/lib/gdb/styling.py    |  59 +++++++++++-
 gdb/testsuite/gdb.base/style.exp | 159 +++++++++++++++++++++++++------
 4 files changed, 250 insertions(+), 58 deletions(-)

-- 
2.25.4


             reply	other threads:[~2022-08-30 14:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 14:16 Andrew Burgess [this message]
2022-08-30 14:16 ` [PATCH 1/3] gdb/testsuite: extend styling test for libopcodes styling Andrew Burgess
2022-08-30 14:16 ` [PATCH 2/3] gdb: improve disassembler styling when Pygments raises an exception Andrew Burgess
2022-10-08  2:25   ` Simon Marchi
2022-10-08 16:00     ` Andrew Burgess
2022-10-08 16:01       ` Simon Marchi
2022-10-10  9:32         ` Andrew Burgess
2022-10-10 10:31           ` Tom de Vries
2022-10-10 11:16             ` Andrew Burgess
2022-10-10 13:22               ` Tom de Vries
2022-10-10 14:04                 ` Andrew Burgess
2022-10-10 11:03     ` Andrew Burgess
2022-08-30 14:16 ` [PATCH 3/3] gdb/disasm: better intel flavour disassembly styling with Pygments Andrew Burgess
2022-10-02 16:38 ` [PATCH 0/3] Improvements for Pygments based disassembly styling Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1661868744.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).