public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 0/3] AMD64 Displaced Stepping Fix
Date: Thu, 23 Feb 2023 15:46:51 +0000	[thread overview]
Message-ID: <cover.1677167018.git.aburgess@redhat.com> (raw)

I started looking at PR gdb/22921, which turns out to be a bug in our
displaced stepping implementation.

Patch #1 adds some extra debug output that I found super useful.

Patch #2 is a minor cleanup.

Patch #3 fixes the amd64 bug, but does change the displaced stepping
logic a little (specifically how we fixup after displaced stepping),
so this is what needs to most reviewing.

All feedback welcome.

Thanks,
Andrew

---

Andrew Burgess (3):
  gdb: more debug output for displaced stepping
  gdb: remove gdbarch_displaced_step_fixup_p
  gdb: fix reg corruption from displaced stepping on amd64

 gdb/aarch64-tdep.c                            |  19 ++-
 gdb/aarch64-tdep.h                            |   3 +-
 gdb/amd64-tdep.c                              |  28 ++---
 gdb/amd64-tdep.h                              |   2 +-
 gdb/arm-tdep.c                                |  27 ++++-
 gdb/arm-tdep.h                                |   3 +-
 gdb/displaced-stepping.c                      | 113 ++++++++++++------
 gdb/displaced-stepping.h                      |   3 +
 gdb/gdbarch-components.py                     |  26 ++--
 gdb/gdbarch-gen.h                             |  25 ++--
 gdb/gdbarch.c                                 |  18 +--
 gdb/i386-tdep.c                               |  28 ++---
 gdb/i386-tdep.h                               |   2 +-
 gdb/infrun.c                                  |  35 ------
 gdb/infrun.h                                  |   3 -
 gdb/rs6000-tdep.c                             |  15 ++-
 gdb/s390-tdep.c                               |  16 ++-
 .../gdb.arch/amd64-disp-step-signal.c         |  30 +++++
 gdb/testsuite/gdb.arch/amd64-disp-step.S      |  15 +++
 gdb/testsuite/gdb.arch/amd64-disp-step.exp    | 106 +++++++++++++---
 20 files changed, 348 insertions(+), 169 deletions(-)
 create mode 100644 gdb/testsuite/gdb.arch/amd64-disp-step-signal.c


base-commit: 5e39600a691e3ba76acf6ab94edb24844c2e82b7
-- 
2.25.4


             reply	other threads:[~2023-02-23 15:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 15:46 Andrew Burgess [this message]
2023-02-23 15:46 ` [PATCH 1/3] gdb: more debug output for displaced stepping Andrew Burgess
2023-02-23 15:46 ` [PATCH 2/3] gdb: remove gdbarch_displaced_step_fixup_p Andrew Burgess
2023-02-23 15:46 ` [PATCH 3/3] gdb: fix reg corruption from displaced stepping on amd64 Andrew Burgess
2023-03-16 16:39 ` [PATCHv2 0/4] AMD64 Displaced Stepping Fix Andrew Burgess
2023-03-16 16:39   ` [PATCHv2 1/4] gdb: more debug output for displaced stepping Andrew Burgess
2023-03-21 12:29     ` Pedro Alves
2023-03-21 14:41       ` Simon Marchi
2023-03-22 21:17         ` [PATCHv2 0/2] displaced stepping debug improvements Andrew Burgess
2023-03-22 21:17           ` [PATCHv2 1/2] gdb: more debug output for displaced stepping Andrew Burgess
2023-03-22 21:17           ` [PATCHv2 2/2] gdb: move displaced_step_dump_bytes into gdbsupport (and rename) Andrew Burgess
2023-03-27 12:35           ` [PATCHv2 0/2] displaced stepping debug improvements Andrew Burgess
2023-03-21 14:45     ` [PATCHv2 1/4] gdb: more debug output for displaced stepping Simon Marchi
2023-03-16 16:39   ` [PATCHv2 2/4] gdb: remove gdbarch_displaced_step_fixup_p Andrew Burgess
2023-03-21 13:10     ` Pedro Alves
2023-03-22 21:22       ` Andrew Burgess
2023-03-16 16:39   ` [PATCHv2 3/4] gdb: fix reg corruption from displaced stepping on amd64 Andrew Burgess
2023-03-21 13:23     ` Pedro Alves
2023-03-16 16:39   ` [PATCHv2 4/4] gdb: remove redundant signal passing Andrew Burgess
2023-03-27 12:32   ` [PATCHv3 0/3] AMD64 Displaced Stepping Fix Andrew Burgess
2023-03-27 12:32     ` [PATCHv3 1/3] gdb: more debug output for displaced stepping Andrew Burgess
2023-03-28 13:05       ` Simon Marchi
2023-03-28 15:08         ` Andrew Burgess
2023-03-28 15:11           ` Simon Marchi
2023-03-29  9:42             ` Andrew Burgess
2023-03-27 12:32     ` [PATCHv3 2/3] gdb: move displaced_step_dump_bytes into gdbsupport (and rename) Andrew Burgess
2023-03-28 13:10       ` Simon Marchi
2023-03-29  9:43         ` Andrew Burgess
2023-03-27 12:32     ` [PATCHv3 3/3] gdb: fix reg corruption from displaced stepping on amd64 Andrew Burgess
2023-03-29  9:43       ` Pedro Alves
2023-03-28 12:33     ` [PATCHv3 0/3] AMD64 Displaced Stepping Fix Simon Marchi
2023-03-28 15:29       ` Andrew Burgess
2023-03-29 13:46     ` [PATCHv4] gdb: fix reg corruption from displaced stepping on amd64 Andrew Burgess
2023-04-04 13:03       ` Pedro Alves
2023-04-06 13:29         ` Andrew Burgess
2023-04-06 15:38           ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1677167018.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).