[PATCH 00/16] Inferior argument (inc for remote targets) changes

[Andrew Burgess <aburgess@redhat.com>]

This series relates to bug PR gdb/28392.  For background, check out
this series:

  https://inbox.sourceware.org/gdb-patches/20211022071933.3478427-1-m.weghorn@posteo.de

which is a previous attempt to address this bug.

It might also be worth reading:

  https://inbox.sourceware.org/gdb-patches/2b98ca58e47638b4760d86bd6e1fa9a9a79fa2ad.1695817255.git.aburgess@redhat.com

which is a previous series of mine which covers some of the work from
the original patch series.

This series does include many ideas taken from the original patch
series (thanks for Michael (original series author) for his work).  I
think this iteration does include some additional fixes beyond the
original series, also there are more tests and documentation changes
in this version.

There is one small problem: patch #1 is within libiberty.  I have
posted this to the gcc list here:

  https://inbox.sourceware.org/gcc-patches/24a8d878590403540bc9b579ba58805985a4d2f7.1701881419.git.aburgess@redhat.com/

However, GCC is currently in stage 4 of its release cycle, so I'm not
expecting to see that patch merged before April, I've expanded on this
more within the patch #1 email.

Still, there's plenty here to comment on, and I figure between now and
April I can address any feedback that's given.

Thanks,
Andrew

---

Andrew Burgess (14):
  libiberty/buildargv: POSIX behaviour for backslash handling
  gdb/testsuite: add some xfail in gdb.base/startup-with-shell.exp
  gdb: remove the !startup_with_shell path from
    construct_inferior_arguments
  gdbserver: convert program_args to a single string
  gdbsupport: have construct_inferior_arguments take an escape function
  gdbsupport: split escape_shell_characters in two
  gdb: move remote arg splitting and joining into gdbsupport/
  gdb/python: change escaping rules when setting arguments
  gdb: add remote argument passing self tests
  gdb/gdbserver: pass inferior arguments as a single string
  gdb: allow 'set args' and run commands to contain newlines
  gdb/gdbserver: remove some uses of free_vector_argv
  gdb: new maintenance command to help debug remote argument issues
  gdb/gdbserver: rework argument splitting and joining

Michael Weghorn (2):
  gdb: Support some escaping of args with startup-with-shell being off
  gdb/gdbserver: add a '--no-escape-args' command line option

 gdb/Makefile.in                               |   1 +
 gdb/NEWS                                      |  41 +++
 gdb/doc/gdb.texinfo                           | 191 ++++++++++++-
 gdb/doc/python.texi                           |   7 +-
 gdb/infcmd.c                                  | 128 ++++++++-
 gdb/inferior.c                                |   8 -
 gdb/inferior.h                                |   7 +-
 gdb/main.c                                    |  30 +-
 gdb/nat/fork-inferior.c                       |  84 ++----
 gdb/python/py-inferior.c                      |   7 +-
 gdb/remote.c                                  |  94 ++++++-
 gdb/testsuite/gdb.base/args.exp               | 137 ++++++---
 gdb/testsuite/gdb.base/inferior-args.exp      | 215 +++++++++++++--
 .../gdb.base/maint-test-remote-args.exp       |  40 +++
 gdb/testsuite/gdb.base/startup-with-shell.exp | 143 ++++++++--
 gdb/testsuite/gdb.python/py-inferior.exp      |  36 ++-
 gdb/testsuite/gdb.server/inferior-args.c      |  27 ++
 gdb/testsuite/gdb.server/inferior-args.exp    | 157 +++++++++++
 gdb/unittests/remote-arg-selftests.c          | 172 ++++++++++++
 gdbserver/linux-low.cc                        |   5 +-
 gdbserver/linux-low.h                         |   2 +-
 gdbserver/netbsd-low.cc                       |   6 +-
 gdbserver/netbsd-low.h                        |   2 +-
 gdbserver/server.cc                           |  74 +++--
 gdbserver/server.h                            |   5 +
 gdbserver/target.h                            |   6 +-
 gdbserver/win32-low.cc                        |   7 +-
 gdbserver/win32-low.h                         |   2 +-
 gdbsupport/Makefile.am                        |   1 +
 gdbsupport/Makefile.in                        |  13 +-
 gdbsupport/common-inferior.cc                 | 207 +++++++++-----
 gdbsupport/common-inferior.h                  |  29 +-
 gdbsupport/remote-args.cc                     | 260 ++++++++++++++++++
 gdbsupport/remote-args.h                      |  44 +++
 libiberty/argv.c                              |   8 +-
 libiberty/testsuite/test-expandargv.c         |  34 +++
 36 files changed, 1927 insertions(+), 303 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/maint-test-remote-args.exp
 create mode 100644 gdb/testsuite/gdb.server/inferior-args.c
 create mode 100644 gdb/testsuite/gdb.server/inferior-args.exp
 create mode 100644 gdb/unittests/remote-arg-selftests.c
 create mode 100644 gdbsupport/remote-args.cc
 create mode 100644 gdbsupport/remote-args.h


base-commit: b7a5722ebdd24a0d15d56e96d30a649ea1d7b0ee
-- 
2.25.4