Re: [PATCH 16/16] gdb/gdbserver: rework argument splitting and joining

[Keith Seitz <keiths@redhat.com>]

On 1/9/24 06:26, Andrew Burgess wrote:

> I propose that the rules be something like:
> 
>    + GDB removes the quotes, and escapes all special shell characters
>      except for the following:
> 
>    + Whitespace is not escaped, the remote is expected to escape any
>      whitespace within an argument,
> 
>    + Quote characters are not escaped, the remote is expected to escape
>      any single or double quote characters within an argument.
> 
>    + Any other special shell characters will have been escaped, if
>      needed, by GDB, and the escaping included in the transmitted
>      argument.

This is a difficult situation to resolve, isn't it? After reading
through your tests, I believe I have a tiny understanding of what
these rules are doing.

In the end, you've given this far more thought (and play) than I have
while attempting to review this.

Having said that, I only have typos to point out.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 6ff059d14ed..cc9c5ef0ccc 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -43137,6 +43137,19 @@
>   @var{argument} string, which includes all inferior arguments,
>   separated with whitespace.
>   
> +If @value{GDBN} didn't offer @samp{single-inf-arg+}, or the remote
> +didn't choose to use this feature, then @value{GDBN} will split the
> +inferior arguments before passing them to the remote target.  Single
> +and double quotes surrounding any argument will have been removed by
> +@value{GDBN}.  Any special shell characters within each argument will
> +have been escaped with a backslash character except for quote and
> +whitespace characters, these will not be escaped within the arguments,
> +the remote target is expected to escape these characters itself.
> +
> +These slightly complex rules exist for backward compatibility reasons.
> +When implementing a new remote target it is suggested that the
> +@samp{single-inf-arg} feature be supported.

"When implementing a new remote target," (missing comma)

> +
>   @c FIXME:  What about non-stop mode?
>   
>   This packet is only available in extended mode (@pxref{extended mode}).

Keith