From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Mention process_stratum in inferior::priv comment
Date: Mon, 14 Aug 2023 13:34:48 -0700 [thread overview]
Message-ID: <d13e7816-39d7-fe8e-2315-2bea5a70de85@FreeBSD.org> (raw)
In-Reply-To: <20230814180733.2158338-1-tromey@adacore.com>
On 8/14/23 11:07 AM, Tom Tromey via Gdb-patches wrote:
> From what I can tell, inferior::priv is reserved for the
> process_stratum target. It seems to me that it has to be, because
> currenlty only such targets use it, and if a target at another stratum
> started using this field, then conflicts could occur. This patch
> documents this.
> ---
> gdb/inferior.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/inferior.h b/gdb/inferior.h
> index 712f9b3f330..8f300a5bcc5 100644
> --- a/gdb/inferior.h
> +++ b/gdb/inferior.h
> @@ -633,7 +633,7 @@ class inferior : public refcounted_object,
> attach or handling a fork child. */
> bool in_initial_library_scan = false;
>
> - /* Private data used by the target vector implementation. */
> + /* Private data used by the process_stratum target. */
> std::unique_ptr<private_inferior> priv;
>
> /* HAS_EXIT_CODE is true if the inferior exited with an exit code.
Reviewed-by: John Baldwin <jhb@FreeBSD.org>
The only two current users are darwin-nat and remote (and I'm
about to add one in fbsd-nat)
--
John Baldwin
prev parent reply other threads:[~2023-08-14 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 18:07 Tom Tromey
2023-08-14 20:34 ` John Baldwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13e7816-39d7-fe8e-2315-2bea5a70de85@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).