Re: [PATCH] gdb/python: Allow SIGTRAMP_FRAME python unwinders to be created.

["Rémi Bernon" <rbernon@codeweavers.com>]

On 3/14/24 14:00, Guinevere Larsen wrote:
> On 14/02/2024 22:58, Rémi Bernon wrote:
>> Wine now executes Win32 code on a separate stack for its Unix code. It
>> switches from one stack to another on through specific functions, and
>> without any custom unwinders, debugging Wine in Gdb will only let you
>> see the frames of either the Win32 side, or the Unix side.
>>
>> The Win32 and Unix call stacks are actually interleaved, with Unix code
>> sometimes calling back into Win32. Using a custom Python frame unwinder
>> we can provide Gdb with the information it needs to join both toghether
>> and show a complete interleaved call stack. However, Gdb will often stop
>> unwinding as it will see the frames from one stack as inner the frames
>> from the other stack.
>>
>> This allows to write custom unwinders to produce SIGTRAMP_FRAME typed
>> frames, which bypasses this restriction and will show the Win32 / Unix
>> gate as a signal frame.
> 
> Hi!
> 
> Sorry for taking a long time for to review.
> 
> This looks like a good improvement. It would be nice if you could 
> provide a test, but I'm not sure if you are able to manufacture a 
> trampoline frame for a test. If it isn't possible to make a test patch 
> LGTM: Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
> 
> I hope a responsible maintainer is able to approve this soon (or explain 
> how to make a faux trampoline frame to test).
> 

Thanks for the feedback! I have no idea how to add a test, but I'll try 
to figure something up.

-- 
Rémi Bernon <rbernon@codeweavers.com>