* [PATCH] gdb: remove unnecessary NULL checks for return value of value_from_register
@ 2024-01-19 15:35 Simon Marchi
2024-01-19 16:26 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2024-01-19 15:35 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
value_from_register can't return nullptr, remove some NULL checks.
Change-Id: Ia6b32b8f86e593c535e3678a89dffe5544eb7ab0
---
gdb/findvar.c | 23 +++--------------------
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/gdb/findvar.c b/gdb/findvar.c
index d0bb3fd320e7..37b859c2347d 100644
--- a/gdb/findvar.c
+++ b/gdb/findvar.c
@@ -623,29 +623,12 @@ language_defn::read_var_value (struct symbol *var,
{
int regno = SYMBOL_REGISTER_OPS (var)
->register_number (var, get_frame_arch (frame));
- struct value *regval;
if (var->aclass () == LOC_REGPARM_ADDR)
- {
- regval = value_from_register (lookup_pointer_type (type),
- regno,
- frame);
-
- if (regval == NULL)
- error (_("Value of register variable not available for `%s'."),
- var->print_name ());
-
- addr = value_as_address (regval);
- }
+ addr = value_as_address
+ (value_from_register (lookup_pointer_type (type), regno, frame));
else
- {
- regval = value_from_register (type, regno, frame);
-
- if (regval == NULL)
- error (_("Value of register variable not available for `%s'."),
- var->print_name ());
- return regval;
- }
+ return value_from_register (type, regno, frame);
}
break;
base-commit: dbca3300ea7ad55dfd3dfed29d8a6386736138cd
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb: remove unnecessary NULL checks for return value of value_from_register
2024-01-19 15:35 [PATCH] gdb: remove unnecessary NULL checks for return value of value_from_register Simon Marchi
@ 2024-01-19 16:26 ` Tom Tromey
2024-01-19 16:29 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2024-01-19 16:26 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> value_from_register can't return nullptr, remove some NULL checks.
Ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb: remove unnecessary NULL checks for return value of value_from_register
2024-01-19 16:26 ` Tom Tromey
@ 2024-01-19 16:29 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2024-01-19 16:29 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 1/19/24 11:26, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> value_from_register can't return nullptr, remove some NULL checks.
>
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-19 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-19 15:35 [PATCH] gdb: remove unnecessary NULL checks for return value of value_from_register Simon Marchi
2024-01-19 16:26 ` Tom Tromey
2024-01-19 16:29 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).