Re: [PATCH v3] gdb: RISC-V: Refine lr/sc sequence support

[Yang Liu <liuyang22@iscas.ac.cn>]

On 2024/1/12 16:43, Guinevere Larsen wrote:

> On 12/01/2024 07:39, Palmer Dabbelt wrote:
>> On Thu, 11 Jan 2024 22:27:32 PST (-0800), liuyang22@iscas.ac.cn wrote:
>>> On 2024/1/12 02:09, Tom Tromey wrote:
>>>
>>>>>>>>> Yang Liu <liuyang22@iscas.ac.cn> writes:
>>>>> A gentle reminder: this patch has been approved for some time now, 
>>>>> but
>>>>> I've noticed it hasn't been merged into the codebase. Has it been
>>>>> overlooked?
>>>> I don't really know the status of this, but if you have copyright 
>>>> papers
>>>> in place, we can arrange for write-after-approval access.
>>>>
>>>> If you don't then I suspect we will need them, because this patch is
>>>> over the size limit.
>>>
>>> I'm an employee of ISCAS (Institute of Software Chinese Academy of
>>> Sciences), we've signed the copyright papers to binutils-gdb. Please
>>> help arrange this.
>>
>> As far as I can tell the ISCAS copyright assignment includes GDB. 
>> Maybe Andrew just reviewed it thinking you guys had commit access?  
>> I'm not exactly sure what "Approved-By" means.
>
> You got it right on what "Approved-By" means. Once Yang gets added to 
> the write-after-approval list, she is free to push this commit to the 
> master branch when her patch gets that tag. (Or, a maintainer can 
> merge her patch in without giving that access if Yang thinks she won't 
> contribute further).
I'll probably contribute more to gdb. By the way, I go by he/him 
pronouns. ;)
> For the complete explanation of the tags, a patch was merged recently 
> explaining how they work in the gdb/MAINTAINERS file. For convenience, 
> here's a link to the final version of the text: 
> https://inbox.sourceware.org/gdb-patches/20231207173415.2311804-2-blarsen@redhat.com/
>
>>
>> It looks generally reasonable to me, so
>>
>> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
>>
>> if that helps any...
> Hopefully this goes in soon!

Thank you all for the explanations and sorting this out!

Yang Liu