From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: make use of std::string in dbxread.c
Date: Sat, 19 Feb 2022 20:27:20 -0500 [thread overview]
Message-ID: <dba3f07d-bf7b-645e-903c-6e6fd07dc526@polymtl.ca> (raw)
In-Reply-To: <854b644e7c6943d0668aee665203265557156a15.1645300222.git.aburgess@redhat.com>
On 2022-02-19 14:51, Andrew Burgess via Gdb-patches wrote:
> While taking a look through dbxread.c I spotted a couple of places
> where making use of std::string would remove the need for manual
> memory allocation and memcpy.
>
> There should be no user visible changes after this commit.
LGTM.
It's not really related, but there is the exact same code that could be
changed in the exact same way in xcoffread.c, it would be nice to change
it as well.
Simon
next prev parent reply other threads:[~2022-02-20 1:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 19:51 [PATCH 0/2] fix for the stabs debug parser Andrew Burgess
2022-02-19 19:51 ` [PATCH 1/2] gdb: make use of std::string in dbxread.c Andrew Burgess
2022-02-20 1:27 ` Simon Marchi [this message]
2022-02-21 11:50 ` Andrew Burgess
2022-02-19 19:51 ` [PATCH 2/2] gdb: avoid nullptr access in dbxread.c from read_dbx_symtab Andrew Burgess
2022-02-20 1:30 ` Simon Marchi
2022-02-21 11:51 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba3f07d-bf7b-645e-903c-6e6fd07dc526@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).