* [PATCH v2] gdb: Fix false match issue in skip_prologue_using_linetable
@ 2023-04-18 3:16 WANG Rui
2023-04-18 12:11 ` Tom de Vries
0 siblings, 1 reply; 2+ messages in thread
From: WANG Rui @ 2023-04-18 3:16 UTC (permalink / raw)
To: gdb-patches; +Cc: Lancelot SIX, WANG Rui
We should exclude matches to the ending PC to prevent false matches with the
next function, as prologue_end is located at the end PC.
<fun1>:
0x00: ... <-- start_pc
0x04: ...
0x08: ... <-- breakpoint
0x0c: ret
<fun2>:
0x10: ret <-- end_pc | prologue_end of fun2
---
gdb/symtab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 9e9798676cb..a789512d60b 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3705,7 +3705,7 @@ skip_prologue_using_linetable (CORE_ADDR func_addr)
for (;
(it < linetable->item + linetable->nitems
- && it->raw_pc () <= unrel_end);
+ && it->raw_pc () < unrel_end);
it++)
if (it->prologue_end)
return {it->pc (objfile)};
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gdb: Fix false match issue in skip_prologue_using_linetable
2023-04-18 3:16 [PATCH v2] gdb: Fix false match issue in skip_prologue_using_linetable WANG Rui
@ 2023-04-18 12:11 ` Tom de Vries
0 siblings, 0 replies; 2+ messages in thread
From: Tom de Vries @ 2023-04-18 12:11 UTC (permalink / raw)
To: WANG Rui, gdb-patches; +Cc: Lancelot SIX
On 4/18/23 05:16, WANG Rui wrote:
I've submitted a v3, including test-case here (
https://sourceware.org/pipermail/gdb-patches/2023-April/198967.html ).
Thanks,
- Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-18 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 3:16 [PATCH v2] gdb: Fix false match issue in skip_prologue_using_linetable WANG Rui
2023-04-18 12:11 ` Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).