From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/7] First cleanup of defs.h
Date: Mon, 22 Apr 2024 15:55:34 -0700 [thread overview]
Message-ID: <dd4f3eef-55e7-4549-8b30-1b67fff53b66@FreeBSD.org> (raw)
In-Reply-To: <20240422201157.46375-1-simon.marchi@efficios.com>
On 4/22/24 1:10 PM, Simon Marchi wrote:
> Here is a first batch of patches that remove things from defs.h, trying
> to sort them in more appropriate places.
>
> Simon Marchi (7):
> gdb: move two declarations out of defs.h
> gdb: move `enum compile_i_scope_types` to compile/compile.h
> gdb: remove extract_long_unsigned_integer
> gdb: move store/extract integer functions to
> extract-store-integer.{c,h}
> gdb: move RequireLongest to gdbsupport/traits.h
> gdb: don't include hashtab.h in defs.h
> gdb: don't include gdbsupport/array-view.h in defs.h
These all look ok to me.
Approved-By: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
next prev parent reply other threads:[~2024-04-22 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 20:10 Simon Marchi
2024-04-22 20:10 ` [PATCH 1/7] gdb: move two declarations out " Simon Marchi
2024-04-22 20:10 ` [PATCH 2/7] gdb: move `enum compile_i_scope_types` to compile/compile.h Simon Marchi
2024-04-22 20:10 ` [PATCH 3/7] gdb: remove extract_long_unsigned_integer Simon Marchi
2024-04-22 20:10 ` [PATCH 4/7] gdb: move store/extract integer functions to extract-store-integer.{c,h} Simon Marchi
2024-04-23 18:03 ` [PATCH 4/7] gdb: move store/extract integer functions to extract-store-integer.{c, h} Pedro Alves
2024-04-23 19:10 ` Simon Marchi
2024-04-23 19:40 ` Pedro Alves
2024-04-22 20:10 ` [PATCH 5/7] gdb: move RequireLongest to gdbsupport/traits.h Simon Marchi
2024-04-22 20:10 ` [PATCH 6/7] gdb: don't include hashtab.h in defs.h Simon Marchi
2024-04-22 20:10 ` [PATCH 7/7] gdb: don't include gdbsupport/array-view.h " Simon Marchi
2024-04-22 22:55 ` John Baldwin [this message]
2024-04-23 1:38 ` [PATCH 0/7] First cleanup of defs.h Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4f3eef-55e7-4549-8b30-1b67fff53b66@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).