From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Issue error on erroneous expression
Date: Mon, 20 Feb 2023 10:55:09 +0100 [thread overview]
Message-ID: <dd83c1bd-7e2b-94c8-23eb-88b54dbf7289@redhat.com> (raw)
In-Reply-To: <20230218155747.3723021-1-tom@tromey.com>
On 18/02/2023 16:57, Tom Tromey wrote:
> A while back I discovered that this does not issue an error:
>
> (gdb) p $x = (void * ) 57
> $3 = (void *) 0x39
> (gdb) p $x + 7 = 3
> $6 = (void *) 0x3
>
> This patch fixes the bug.
> Regression tested on x86-64 Fedora 36.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312
Hi Tom,
This seems like a pretty obvious fix, and I also don't see any regressions.
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
--
Cheers,
Bruno
prev parent reply other threads:[~2023-02-20 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 15:57 Tom Tromey
2023-02-20 9:55 ` Bruno Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd83c1bd-7e2b-94c8-23eb-88b54dbf7289@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).