public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: Carl Love <cel@us.ibm.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.ada/float-bits.exp for powerpc64le
Date: Thu, 1 Dec 2022 21:01:10 +0000	[thread overview]
Message-ID: <de2abda6-3e42-6e6c-4195-a39372007f3f@arm.com> (raw)
In-Reply-To: <df9d2bc4-c03f-3cb8-6614-509648f4a587@arm.com>

On 12/1/22 20:51, Luis Machado wrote:
> On 12/1/22 14:40, Tom de Vries wrote:
>> On 12/1/22 14:49, Luis Machado wrote:
>>> This change seems to be causing a timeout on aarch64-linux Ubuntu 22.04.
>>>
>>> FAIL: gdb.ada/float-bits.exp: maint print architecture (timeout)
>>>
>>> # of expected passes            12
>>> # of unexpected failures        1
>>>
>>> It is as if the listing of the architecture fields didn't have time to finish.
>>>
>>
>> Can you see if this fixes things?
>>
>> Thanks,
>> - Tom
> 
> I checked the patch and it doesn't seem to help. It still times out.
> 
> I briefly investigated this and it looks like a (gdb) prompt gets output when it shouldn't.
> 
> gdbarch_dump: read_core_file_mappings = <0xaaaac98fb7f0>
> (gdb) aarch64_dump_tdep: Lowest pc = 0x0x8000 <the prompt is here, hitting enter gives another prompt below)
> (gdb)
> 
> This doesn't seem to be related to your patch, but something else.

Ah, the tdep dumper for aarch64 is missing a "\n"! So the prompt seems to be output in the beginning of the same line.

Odd, and slightly fragile.

In any case, this is easily fixed with the \n addition. I'll push an obvious change for that.

Sorry for the noise.

  reply	other threads:[~2022-12-01 21:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 14:00 Tom de Vries
2022-11-30 14:51 ` Tom Tromey
2022-11-30 16:18 ` Carl Love
2022-12-01 13:49 ` Luis Machado
2022-12-01 14:40   ` Tom de Vries
2022-12-01 20:51     ` Luis Machado
2022-12-01 21:01       ` Luis Machado [this message]
2022-12-02  7:59         ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de2abda6-3e42-6e6c-4195-a39372007f3f@arm.com \
    --to=luis.machado@arm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=cel@us.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).