Re: [PATCH] [gdb/testsuite] Fix gdb.ada/float-bits.exp for powerpc64le

[Tom de Vries <tdevries@suse.de>]

On 12/1/22 22:01, Luis Machado wrote:
> On 12/1/22 20:51, Luis Machado wrote:
>> On 12/1/22 14:40, Tom de Vries wrote:
>>> On 12/1/22 14:49, Luis Machado wrote:
>>>> This change seems to be causing a timeout on aarch64-linux Ubuntu 
>>>> 22.04.
>>>>
>>>> FAIL: gdb.ada/float-bits.exp: maint print architecture (timeout)
>>>>
>>>> # of expected passes            12
>>>> # of unexpected failures        1
>>>>
>>>> It is as if the listing of the architecture fields didn't have time 
>>>> to finish.
>>>>
>>>
>>> Can you see if this fixes things?
>>>
>>> Thanks,
>>> - Tom
>>
>> I checked the patch and it doesn't seem to help. It still times out.
>>
>> I briefly investigated this and it looks like a (gdb) prompt gets 
>> output when it shouldn't.
>>
>> gdbarch_dump: read_core_file_mappings = <0xaaaac98fb7f0>
>> (gdb) aarch64_dump_tdep: Lowest pc = 0x0x8000 <the prompt is here, 
>> hitting enter gives another prompt below)
>> (gdb)
>>
>> This doesn't seem to be related to your patch, but something else.
> 
> Ah, the tdep dumper for aarch64 is missing a "\n"! So the prompt seems 
> to be output in the beginning of the same line.
> 
> Odd, and slightly fragile.
> 
> In any case, this is easily fixed with the \n addition. I'll push an 
> obvious change for that.
> 
> Sorry for the noise.

No problem :)

Now that I've done the work anyway, I've pushed the line-by-line reading 
patch with an updated commit message ( 
https://sourceware.org/pipermail/gdb-patches/2022-December/194408.html ).

Thanks,
- Tom