Re: [PATCH v6 2/7] add btrace coresight related commands

[Zied Guermazi <zied.guermazi@trande.de>]

Hi Eli,

there is no change in documentation part. so we can consider this part 
as approved.

Kind Regards

Zied Guermazi

On 01.06.21 14:07, Eli Zaretskii wrote:
>> From: Zied Guermazi <zied.guermazi@trande.de>
>> Date: Mon, 31 May 2021 23:33:02 +0200
>> Cc: Zied Guermazi <zied.guermazi@trande.de>
>>
>> This patch extends the commands needed for using branch tracing
>> with ARM CoreSight traces.
>> Those commands are:
>> set record btrace etm sink
>> set record btrace etm buffer-size
>> record btrace etm
>>
>> gdb/ChangeLog
>>
>> 	* NEWS: list new commands for extending btrace
>> 	to support using ARM CoreSight Traces.
>> 	* record-btrace.c (record_btrace_print_etm_conf): New.
>> 	(record_btrace_print_conf): handle BTRACE_FORMAT_ETM.
>> 	(cmd_record_btrace_etm_start): New.
>> 	(cmd_record_btrace_start): handle starting ETM tracing.
>> 	(cmd_show_record_btrace_cpu): extend for ARM cpus.
>> 	(show_record_etm_buffer_size_value): New.
>> 	(_initialize_record_btrace): add commands for ETM traces.
>> 	(record_start): add starting ETM traces.
>>
>> gdb/doc/ChangeLog
>>
>> 	* gdb.texinfo (Process Record and Replay): Document extending
>> 	GDB btrace commands to support using ARM CoreSight traces.
>>
>> gdbsupport/ChangeLog
>>
>> 	* btrace-common.h (btrace_format): add BTRACE_FORMAT_ETM
>> 	to the enum.
>> 	(btrace_config_etm): new struct.
>> 	(btrace_config): add btrace_config_etm etm.
>> 	* btrace-common.cc (btrace_format_string): add BTRACE_FORMAT_ETM.
>> 	(btrace_format_short_string): add BTRACE_FORMAT_ETM.
> Are there any changes in the documentation parts since the last time?
> If not, I think I already approved the doc parts.
>
> Thanks.