From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] remote.c: Allow inferior to reply with an error
Date: Fri, 6 Jan 2023 13:59:25 -0500 [thread overview]
Message-ID: <e422ed61-fa67-33d6-95a2-663cc36a5e68@simark.ca> (raw)
In-Reply-To: <87o7rby9ws.fsf@redhat.com>
> I don't think this should be merged.
>
> I don't think changing this error into a warning is a good idea.
> Surely, if GDB can't switch to the directory that the user expects, then
> we should stop and tell the user that we can't do what they've asked,
> then the user could update things and try again.
>
> As a (maybe extreme) example, what if the user was debugging 'rm -f *',
> but first changed from their $HOME directory to '/tmp/test-dir/'. If
> the requested directory doesn't exist then we're going to just carry on
> and run the test in $HOME .... that seems like a bad idea to me.
I agree.
Simon
next prev parent reply other threads:[~2023-01-06 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 11:39
2023-01-04 14:42 ` Eli Zaretskii
2023-01-05 18:16 ` Tom Tromey
2023-01-06 15:12 ` Andrew Burgess
2023-01-06 18:59 ` Simon Marchi [this message]
2023-01-09 12:55 ` Alexandra Petlanova Hajkova
2023-01-09 17:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e422ed61-fa67-33d6-95a2-663cc36a5e68@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).