* [RFA] Update "func" help text to GNU standards
@ 2018-06-05 16:40 Tom Tromey
2018-06-27 18:46 ` Andrew Burgess
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2018-06-05 16:40 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
In my earlier series to change help text to follow the GNU standards
for metasyntactic variables, I missed one: the "func" command. This
patch updates its help text.
Tested by the buildbot.
gdb/ChangeLog
2018-06-05 Tom Tromey <tom@tromey.com>
* stack.c (_initialize_stack): Update "func" help text.
---
gdb/ChangeLog | 4 ++++
gdb/stack.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/stack.c b/gdb/stack.c
index 97ebc8bc23f..caa71c1bd4e 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -2556,8 +2556,8 @@ on this backtrace."));
if (dbx_commands)
add_com ("func", class_stack, func_command, _("\
-Select the stack frame that contains <func>.\n\
-Usage: func <name>"));
+Select the stack frame that contains NAME.\n\
+Usage: func NAME"));
add_setshow_enum_cmd ("frame-arguments", class_stack,
print_frame_arguments_choices, &print_frame_arguments,
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Update "func" help text to GNU standards
2018-06-05 16:40 [RFA] Update "func" help text to GNU standards Tom Tromey
@ 2018-06-27 18:46 ` Andrew Burgess
2018-06-27 20:26 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2018-06-27 18:46 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
* Tom Tromey <tom@tromey.com> [2018-06-05 10:40:17 -0600]:
> In my earlier series to change help text to follow the GNU standards
> for metasyntactic variables, I missed one: the "func" command. This
> patch updates its help text.
>
> Tested by the buildbot.
>
> gdb/ChangeLog
> 2018-06-05 Tom Tromey <tom@tromey.com>
>
> * stack.c (_initialize_stack): Update "func" help text.
FWIW this looks good to me.
Thanks,
Andrew
> ---
> gdb/ChangeLog | 4 ++++
> gdb/stack.c | 4 ++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/stack.c b/gdb/stack.c
> index 97ebc8bc23f..caa71c1bd4e 100644
> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -2556,8 +2556,8 @@ on this backtrace."));
>
> if (dbx_commands)
> add_com ("func", class_stack, func_command, _("\
> -Select the stack frame that contains <func>.\n\
> -Usage: func <name>"));
> +Select the stack frame that contains NAME.\n\
> +Usage: func NAME"));
>
> add_setshow_enum_cmd ("frame-arguments", class_stack,
> print_frame_arguments_choices, &print_frame_arguments,
> --
> 2.13.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Update "func" help text to GNU standards
2018-06-27 18:46 ` Andrew Burgess
@ 2018-06-27 20:26 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2018-06-27 20:26 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches, Tom Tromey
On 2018-06-27 14:46, Andrew Burgess wrote:
> * Tom Tromey <tom@tromey.com> [2018-06-05 10:40:17 -0600]:
>
>> In my earlier series to change help text to follow the GNU standards
>> for metasyntactic variables, I missed one: the "func" command. This
>> patch updates its help text.
>>
>> Tested by the buildbot.
>>
>> gdb/ChangeLog
>> 2018-06-05 Tom Tromey <tom@tromey.com>
>>
>> * stack.c (_initialize_stack): Update "func" help text.
>
> FWIW this looks good to me.
>
> Thanks,
> Andrew
LGTM too, thanks!
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-27 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 16:40 [RFA] Update "func" help text to GNU standards Tom Tromey
2018-06-27 18:46 ` Andrew Burgess
2018-06-27 20:26 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).