Re: [PATCH] gdb/testsuite: fail if gdb_start_cmd fails

[Bruno Larsen <blarsen@redhat.com>]

On 18/11/2022 17:06, Simon Marchi via Gdb-patches wrote:
> I broke gdb.ada/start.exp, and did not notice it, because it outputs an
> UNTESTED if gdb_start_cmd fails.  I don't really see when start would
> fail and it's not a problem that should be looked at.  Change all spots
> that call untested after a gdb_start_cmd failure, use fail instead.
>
> Doing so caused some failures with the native-gdbserver board.  Some
> tests that use "start" were relying on the fact that start would fail
> with that board to just return with "untested".  Change them to add an
> early return if use_gdb_stub returns true.
>
> Some gdb.pascal tests also failed with native-gdbserver, because they
> did use gdb_start_cmd to start the inferior, for no good reason.
> Convert them to use runto_main instead, which does the right thing if
> the target is a stub.
>
> A further refactoring could be to make gdb_start_cmd match the expected
> breakpoint hit and the prompt, which it doesn't do currently (it leaves
> that to the callers, but not all of them do).
>
> Change-Id: I097370851213e798ff29fb6cf8ba25ef7d2be007

Hi Simon,

This patch makes sense to me, and testing shows no regressions.

Reviewed-By: Bruno Larsen <blarsen@redhat.com>

--
Cheers,
Bruno