From: Luis Machado <luis.machado@arm.com>
To: Tom de Vries <tdevries@suse.de>,
Kevin Buettner <kevinb@redhat.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: WANG Rui <r@hev.cc>
Subject: Re: [PATCH v3] gdb: Fix false match issue in skip_prologue_using_linetable
Date: Mon, 24 Apr 2023 13:53:37 +0100 [thread overview]
Message-ID: <ea16e7fc-71f4-43db-87b1-4d6584be9b1a@arm.com> (raw)
In-Reply-To: <276f25d7-ab32-268f-0875-70cab6180e8d@suse.de>
On 4/22/23 09:01, Tom de Vries via Gdb-patches wrote:
> On 4/21/23 20:03, Kevin Buettner wrote:
>> Hi Tom,
>>
>> On Tue, 18 Apr 2023 14:15:06 +0200
>> Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> wrote:
>>
>>> On 4/18/23 14:09, Tom de Vries via Gdb-patches wrote:
>>>> Co-Authored-By: WANG Rui <r@hev.cc> (fix, tiny change [1])
>>>> Co-Authored-By: Tom de Vries <tdevries@suse.de> (test-case)
>>>>
>>>> [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html
>>>
>>> I'm not used to deal with these matters, so I'd appreciate some
>>> review/approval on this. Is my copyright status assessment correct, and
>>> did I write it up correctly?
>>
>> I refreshed my memory via the link you provided above. Based on what
>> is written there, I conclude that Wang Rui's change is not legally
>> signficant for copyright purposes.
>>
>> Also, I've looked over the Rui's patch as well as your test case, and
>> it looks good to me. So...
>>
>> Approved-by: Kevin Buettner <kevinb@redhat.com>
>>
>
> Hi Kevin,
>
> Thanks for review.
>
> Committed and also backported to gdb-13-branch, because it was a 12 -> 13 regression.
>
> Thanks,
> - Tom
>
For some reason aarch64 is grumpy with this test, and it FAIL's the last comparison.
Maybe aarch64 is broken in this regard?
next prev parent reply other threads:[~2023-04-24 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 12:09 Tom de Vries
2023-04-18 12:15 ` Tom de Vries
2023-04-18 13:14 ` hev
2023-04-21 18:03 ` Kevin Buettner
2023-04-22 8:01 ` Tom de Vries
2023-04-24 12:53 ` Luis Machado [this message]
2023-04-24 14:15 ` Tom de Vries
2023-05-16 14:19 ` Luis Machado
2023-05-16 15:31 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea16e7fc-71f4-43db-87b1-4d6584be9b1a@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=r@hev.cc \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).