From: John Baldwin <jhb@FreeBSD.org>
To: Roland McGrath <mcgrathr@google.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [PATCH users/roland/event-pipe] Avoid conflict with gnulib open/close macros.
Date: Tue, 1 Mar 2022 16:31:53 -0800 [thread overview]
Message-ID: <ea71e2b1-9953-de79-f08b-410330cde7d1@FreeBSD.org> (raw)
In-Reply-To: <CAB=4xhqvmb-EgMc2TcNSzXG3P58Z332XvibC+Gf4zoe3XLv2kg@mail.gmail.com>
On 3/1/22 4:26 PM, Roland McGrath via Gdb-patches wrote:
> [This patch is on sourceware branch users/roland/event-pipe for your
> convenience. I can merge it in myself after approval.]
>
> On some systems, the gnulib configuration will decide to define open
> and/or close as macros to replace the POSIX C functions. This
> interferes with using those names in C++ class or namespace scopes.
I noticed this recently as well (and I authored the event-pipe.cc file).
This is an unfortunate consequence of the gnulib #define approach.
I think this patch is fine (but I'm not an approver).
--
John Baldwin
next prev parent reply other threads:[~2022-03-02 0:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 0:26 Roland McGrath
2022-03-02 0:31 ` John Baldwin [this message]
2022-03-03 18:57 ` Pedro Alves
2022-03-03 19:23 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea71e2b1-9953-de79-f08b-410330cde7d1@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).