Re: [PATCH] gdb: fix -Wmaybe-uninitialized warning in value.c

[Simon Marchi <simon.marchi@efficios.com>]

On 3/2/23 16:00, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> This is because the union field internalvar::u is not initialized when
> Simon> constructing the temporary internalvar object above.  That object is then used
> Simon> for move-construction, and the (implicit) move constructor copies the
> Simon> uninitialized bytes of field u over from the temporary object to the new
> Simon> internalvar object.  The compiler therefore complains that we use uninitialized
> Simon> bytes.  I don't think it's really a problem, because the internalvar object is
> Simon> in the `kind == INTERNALVAR_VOID` state, in which the contents of the union is
> Simon> irrelevant.  Still, mute the warning by default-initializing the union.
> 
> Seems fine to me.
> Reviewed-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Pushed, thanks.

Simon