Re: [PATCH v2 5/5] gdb: disable commit resumed in target_kill

[Simon Marchi <simon.marchi@polymtl.ca>]

>> +proc do_test { action1 action2 } {
>> +    save_vars { ::GDBFLAGS } {
>> +	append ::GDBFLAGS " -ex \"maintenance set target-non-stop on\""
>> +	clean_restart $::binfile
>> +    }
>> +
>> +    # Ensure we are at least after the getpid call, shall we need it.
> 
> s/shall/should/

Fixed.

> 
>> +    if { ![runto "after_getpid"] } {
>> +	return
>> +    }
>> +
>> +    # Some commands below ask for confirmation.  Turn that off for simplicity.
>> +    gdb_test "set confirm off"
>> +    gdb_test -no-prompt-anchor "continue &"
>> +
>> +    if { $action1 == "kill" } {
>> +	gdb_test "kill" "Inferior 1 .* killed.*"
>> +    } elseif { $action1 == "detach" } {
>> +	set child_pid [get_integer_valueof "mypid" -1]
>> +	if { $child_pid == -1 } {
>> +	    fail "failed to extract child pid"
>> +	    return
>> +	}
>> +
>> +	gdb_test "detach" "Inferior 1 .* detached.*" "detach from first instance"
>> +
>> +	# Kill the detached process, to avoid hanging when exiting GDBserver,
>> +	# when testing with the native-extended-gdbserver board.
>> +	remote_exec target "kill $child_pid"
>> +    } elseif { $action1 == "add" } {
>> +	gdb_test "add-inferior -exec $::binfile" \
>> +	    "Added inferior 2 on connection 1.*" "add-inferior"
>> +	gdb_test "inferior 2" "Switching to inferior 2 .*"
>> +    } elseif { $action1 == "none" } {
>> +
>> +    } else {
>> +	error "invalid action 1"
>> +    }
>> +
>> +    if { $action2 == "start" } {
>> +	gdb_test "start" "Temporary breakpoint $::decimal, main .*"
> 
> When I tested using a recent version of master, I needed to change this
> line to:
> 
>   gdb_test "start" "Temporary breakpoint $::decimal\(?:\.$::decimal\)?, main .*"
> 
> this is a result of commit 78805ff8aecf0a8c828fb1e2c344fa3a56655120.

Fixed.

> 
>> +    } elseif { $action2 == "run" } {
>> +	gdb_test "break main" "Breakpoint $::decimal at $::hex.*"
>> +	gdb_test "run" "Breakpoint $::decimal, main .*"
> 
> and I ran into the same issue here:
> 
>   gdb_test "run" "Breakpoint $::decimal\(?:\.$::decimal\)?, main .*"

Fixed, thanks for spotting these.

> With those fixes, this LGTM.

Thanks, will push.

Simon